NameSpace Compatibility #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required as soon as namespace conversion in plugin is done (see LezWatch/lwtv-plugin#393 )
There are no real changes to the theme, just to the wrappers.
Where we used to do this:
( new LWTV_CPTs_Related_Posts() )->related_archive_header( $tag_id );We can now do this:
lwtv_plugin()->get_related_archive_header( $tag_id );Now you don't have to know what class/namespace is what!
Also made better use of checks to ensure functions are available when called (thank you Intellephense!) and we don't allow malformed data to attempt to run.