Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nalgebra upgrade #17

Merged
merged 3 commits into from
Oct 29, 2018
Merged

nalgebra upgrade #17

merged 3 commits into from
Oct 29, 2018

Conversation

hdhoang
Copy link
Contributor

@hdhoang hdhoang commented Oct 28, 2018

due to rust-lang/rust#49799.

I hit a wierd failure with this example:

error[E0308]: mismatched types
  --> examples/show_in_emerald.rs:81:9
   |
81 |         indices,
   |         ^^^^^^^ expected u16, found u32
   |
   = note: expected type `std::vec::Vec<nalgebra::Point<u16, _>>`
              found type `std::vec::Vec<nalgebra::Point<u32, _>>`

I think indices are GLuint, which should still be c_uint/u32. Could you take a closer look?

@Libbum
Copy link
Owner

Libbum commented Oct 28, 2018

Thanks for this. I'm travelling at the moment so won't get to it until tomorrow, but looks good on first glance.

I really should get back to finishing this package properly. Have you found a use for it? Any features you would like added?

@hdhoang
Copy link
Contributor Author

hdhoang commented Oct 28, 2018

Hey, no worry. I'm coming at this from the rust-lang PR, I'm not a user though.

Travis also fails on u16/u32 like above: https://travis-ci.com/hdhoang/spherical-cow/builds/89428375#L1033. I have no idea how that comes up.

@Libbum
Copy link
Owner

Libbum commented Oct 28, 2018

Sure thing. Thanks for the tip-off! Will take a deeper look tomorrow.

@Libbum
Copy link
Owner

Libbum commented Oct 29, 2018

The reason for the failure in emerald was from sebcrozet/kiss3d#130 - WebGL 1.0 compatibility has dropped the size of the faces uint.

@Libbum Libbum merged commit 964fb58 into Libbum:master Oct 29, 2018
@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #17   +/-   ##
====================================
  Coverage      80%   80%           
====================================
  Files           6     6           
  Lines         385   385           
====================================
  Hits          308   308           
  Misses         77    77
Impacted Files Coverage Δ
src/lib.rs 98.78% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6828192...b6d67ba. Read the comment docs.

@hdhoang hdhoang deleted the nalgebra-upgrade branch October 29, 2018 12:24
@hdhoang
Copy link
Contributor Author

hdhoang commented Oct 29, 2018

great to know! thanks for accepting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants