Refactor/ support both Pydantic 1 and 2 #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dict. lock to >= current pydantic
…ut issues with "del"ing attributes
shuds13
reviewed
Oct 26, 2023
… on detected pydantic version. Other model ops are performed based on pydantic version
…ction for dumping specs based on pydantic version
…ins validators for both pydantic versions. pydantic_bindings.py binds validators and other configs to their corresponding classes. only one specs_checkers, utility functions to get/set attributes of pydantic objects
jlnav
changed the title
… retain field defaults and aliases
…etting validator attributes directly didn't work since they didn't get bound to fields. various other cross-version fixes and improvements
shuds13
reviewed
Nov 28, 2023
…ts erroring and displaying multiple?
…ed soon? debugging strings
jlnav
changed the title
jlnav
changed the title
|
A thought I just had was maybe we keep this current implementation through v1, then maybe if we ever do a libE 2.0, we drop pydantic 1 support |
shuds13
reviewed
Dec 6, 2023
Yeah it should. Thanks! |
shuds13
reviewed
Dec 6, 2023
| @@ -60,6 +61,7 @@ | |||
| # from libensemble import logger | |||
| # logger.set_level("DEBUG") # For testing the test | |||
|
|
|||
| warnings.filterwarnings("ignore", category=UserWarning) | |||
shuds13
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1132