Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/ support both Pydantic 1 and 2 #1135

Merged
merged 52 commits into from
Dec 7, 2023
Merged

Refactor/ support both Pydantic 1 and 2 #1135

merged 52 commits into from
Dec 7, 2023

Commits on Oct 16, 2023

  1. kinda large initial commit

    @jlnav
    jlnav committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    fd6ae59 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. avoid recursive-validation issue by validators setting attributes by … 

    …dict. lock to >= current pydantic
    @jlnav
    jlnav committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b13c693 View commit details
    Browse the repository at this point in the history

  2. fix no-attribute by .__dict__.get()

    @jlnav
    jlnav committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    471ba01 View commit details
    Browse the repository at this point in the history

  3. ConfigDict for Platform model, plus apparently new pydantic warns abo… 

    …ut issues with "del"ing attributes
    @jlnav
    jlnav committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    8155551 View commit details
    Browse the repository at this point in the history

  4. skip more steps in deps cache-hit on CI

    @jlnav
    jlnav committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    665c88f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8601273 View commit details
    Browse the repository at this point in the history

  2. tentative change to support both pydantic 1 and pydantic 2

    @jlnav
    jlnav committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e8f20db View commit details
    Browse the repository at this point in the history

  3. attempts to set specs and platforms modules based on pydantic version

    @jlnav
    jlnav committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e86fc54 View commit details
    Browse the repository at this point in the history

  4. Created submodules that import/set versions of specs, platforms based… 

    … on detected pydantic version. Other model ops are performed based on pydantic version
    @jlnav
    jlnav committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3058092 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. typo

    @jlnav
    jlnav committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    01f124b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    584e16e View commit details
    Browse the repository at this point in the history

  3. better variables for determining pydantic version, and specs_dump fun… 

    …ction for dumping specs based on pydantic version
    @jlnav
    jlnav committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    9833c9d View commit details
    Browse the repository at this point in the history

  4. starting universal field and model validators

    @jlnav
    jlnav committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d47ab2d View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    a51d742 View commit details
    Browse the repository at this point in the history

  2. huge refactoring. only a single specs.py for now. validators.py conta… 

    …ins validators for both pydantic versions. pydantic_bindings.py binds validators and other configs to their corresponding classes.

only one specs_checkers, utility functions to get/set attributes of pydantic objects
    @jlnav
    jlnav committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b68d013 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. refactoring docs, turning both platforms.py files back into a single … 

    …file
    @jlnav
    jlnav committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    526b508 View commit details
    Browse the repository at this point in the history

  2. universal platforms.py

    @jlnav
    jlnav committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    06f4889 View commit details
    Browse the repository at this point in the history

  3. desperately trying to figure out how to do cross-version aliases

    @jlnav
    jlnav committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    0b10b91 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. with Pydantic2, we need to use merge_field_infos and model_rebuild to… 

    … retain field defaults and aliases
    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8aa1890 View commit details
    Browse the repository at this point in the history

  2. fix test_models

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fe381d5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    73564ac View commit details
    Browse the repository at this point in the history

  4. using create_model to create new model definitions with validators; s… 

    …etting validator attributes directly didn't work since they didn't get bound to fields. various other cross-version fixes and improvements
    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c915bb1 View commit details
    Browse the repository at this point in the history

  5. tiny fix

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    113dc1e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c563e6d View commit details
    Browse the repository at this point in the history

  7. workflow_dir checking bugfix for pydantic2 validator version

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c9b0e86 View commit details
    Browse the repository at this point in the history

  8. may have just validated a validator

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    245a919 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fcbce07 View commit details
    Browse the repository at this point in the history

  10. dunno why we always need to do this?

    @jlnav
    jlnav committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d9914f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. what in tarnation, are we missing a dependency for compilation somehow?

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    39f6af2 View commit details
    Browse the repository at this point in the history

  2. unpin autodoc pydantic

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0c3e541 View commit details
    Browse the repository at this point in the history

  3. fix pydantic2 validator bug with enabling final_save when save_every_… 

    …k is enabled
    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    112253e View commit details
    Browse the repository at this point in the history

  4. adjust required pydantic version, add jobs for testing old-pydantic

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    10b1378 View commit details
    Browse the repository at this point in the history

  5. presumably fix matrix?

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    04072e5 View commit details
    Browse the repository at this point in the history

  6. missing matrices

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1f6e3de View commit details
    Browse the repository at this point in the history

  7. more matrix fixes

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e2a9bd8 View commit details
    Browse the repository at this point in the history

  8. use cross-version wrapper function instead of model_dump in unit test… 

    … setup
    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c44ecd1 View commit details
    Browse the repository at this point in the history

  9. cross-version test_models

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e9f75be View commit details
    Browse the repository at this point in the history

  10. fix

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    9876a28 View commit details
    Browse the repository at this point in the history

  11. adjusts

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e5fae6e View commit details
    Browse the repository at this point in the history

  12. fix

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    bcc3340 View commit details
    Browse the repository at this point in the history

  13. really dont know why the number of errors is variable, but at least i… 

    …ts erroring and displaying multiple?
    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6c3345e View commit details
    Browse the repository at this point in the history

  14. i just want this to work already...

    @jlnav
    jlnav committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0ea1735 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. change these unsets back to del, adjust cache

    @jlnav
    jlnav committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    468845f View commit details
    Browse the repository at this point in the history

  2. refactoring

    @jlnav
    jlnav committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    d2f63a3 View commit details
    Browse the repository at this point in the history

  3. moving some logic to specs_checkers

    @jlnav
    jlnav committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    54ac7cc View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. ignoring a flakey warning from Pydantic, which will presumably be fix… 

    …ed soon? debugging strings
    @jlnav
    jlnav committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    601fb8a View commit details
    Browse the repository at this point in the history

  2. specs_checker_getattr can now return a default value

    @jlnav
    jlnav committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    76d0e92 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. coverage

    @jlnav
    jlnav committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ec4b706 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4d4d349 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into refactor/pydantic2

    @jlnav
    jlnav committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    180ab0c View commit details
    Browse the repository at this point in the history

  3. adjust new unit test for pydantic 2

    @jlnav
    jlnav committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    bfcd48d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. adjust dependency listings for autodoc_pydantic and pydantic 1.10 low… 

    …er bound
    @jlnav
    jlnav committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    38e715d View commit details
    Browse the repository at this point in the history