Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make displayed and actual point analysis coordinates match #926

Closed
uellue opened this issue Dec 14, 2020 · 1 comment · Fixed by #927
Closed

Make displayed and actual point analysis coordinates match #926

uellue opened this issue Dec 14, 2020 · 1 comment · Fixed by #927
Assignees
Labels
bug Something isn't working
Milestone

Comments

@uellue
Copy link
Member

uellue commented Dec 14, 2020

How to reproduce

  • LiberTEM current master, possibly older versions as well
  • Open a low-resolution dataset, for example 32x32x32x32, with clearly identifiable points (in this case a double diagonal with outliers).
  • Perform a point analysis around the outliers. Disk analysis and frame picking are not affected, others not tested.

Expected results

  • A pixel on the left is selected if the center of the crosshair is within it.
  • As a bonus, the selector position could snap to pixel centers like it does for frame picking.

Observed result

  • The selection area for a pixel seems to be shifted by 1/2 to the lower right. Based on the numerical values, one should use "round()" instead of "floor()" to get the integer point position from float coordinates.

See these pictures:

Centered: correct pixel

Capture-centered

Lower left corner: Wrong pixel selected

Capture-lower-left

Lower right corner: Correct pixel selected

Capture-lower-right

Upper right corner: Wrong pixel selected

Capture-upper-right

Upper left corner: Pixel to the upper left selected (wrong pixel, other outlier)

Capture-upper-left

Just below pixel: Still within selection

Capture-below

Just right of pixel: Still selected

Capture-right

@uellue uellue added the bug Something isn't working label Dec 14, 2020
@uellue uellue added this to the 0.6 milestone Dec 14, 2020
sk1p added a commit to sk1p/LiberTEM that referenced this issue Dec 14, 2020
@sk1p
Copy link
Member

sk1p commented Dec 14, 2020

Thanks for the detailed report, this should be fixed in #927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants