Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape globs to allow special characters in file names #1067

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

uellue
Copy link
Member

@uellue uellue commented Jul 14, 2021

Closes #1066

  • A bit of refactoring to make the code more uniform and easier to test
  • Skip only tests that need test data since the glob tests don't need it

Contributor Checklist:

Reviewer Checklist:

  • /azp run libertem.libertem-data passed

Closes LiberTEM#1066

* A bit of refactoring to make the code more uniform and easier to test
* Skip only tests that need test data since the glob tests don't need it
@uellue uellue added bug Something isn't working file formats and I/O labels Jul 14, 2021
@uellue
Copy link
Member Author

uellue commented Jul 14, 2021

/azp run libertem.libertem-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1067 (bc1d1d8) into master (6b6ca85) will increase coverage by 0.10%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   69.16%   69.27%   +0.10%     
==========================================
  Files         268      268              
  Lines       12564    12572       +8     
  Branches     1767     1769       +2     
==========================================
+ Hits         8690     8709      +19     
+ Misses       3534     3521      -13     
- Partials      340      342       +2     
Impacted Files Coverage Δ
src/libertem/io/dataset/cached.py 77.21% <0.00%> (ø)
src/libertem/io/dataset/k2is.py 77.30% <71.42%> (+0.08%) ⬆️
src/libertem/io/dataset/frms6.py 75.14% <75.00%> (+2.85%) ⬆️
src/libertem/io/dataset/mib.py 67.84% <75.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6ca85...bc1d1d8. Read the comment docs.

@sk1p
Copy link
Member

sk1p commented Jul 14, 2021

/azp run libertem.libertem-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sk1p
Copy link
Member

sk1p commented Jul 14, 2021

Re-running data tests since the locale settings have changed.

Copy link
Member

@sk1p sk1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sk1p sk1p merged commit e1828d4 into LiberTEM:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working file formats and I/O
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-standard characters in path trip MIB reader
2 participants