Convertinging util.js to typescript 3/3 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waylandli
commented
Dec 11, 2021
waylandli
commented
Dec 11, 2021
waylandli
commented
Dec 11, 2021
|
A lot of |
added 3 commits
February 24, 2022 10:35
waylandli
force-pushed
the
chore/util-conversion/28
branch
from
3c2fbe1
to
2b5c510
Compare
shannonwells
approved these changes
Feb 24, 2022
| @@ -27,29 +35,34 @@ class fixedTFramedTransport extends thrift.TFramedTransport { | |||
| */ | |||
|
|
|||
| const previousPageLocation = parquet_thrift.PageLocation.prototype; | |||
| //@ts-ignore | |||
There was a problem hiding this comment.
I haven't been following along on these conversions - are we just using @ts-ignore for now? Is there a plan to convert these to proper TypeScript? @wilwade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Github Issue #28
Part 3 of 3
Converting util.js to typescript
Change summary:
Steps to Verify: