Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow periods in item IDs #836

Closed
rstorey opened this issue Mar 4, 2019 · 0 comments
Closed

Allow periods in item IDs #836

rstorey opened this issue Mar 4, 2019 · 0 comments
Assignees
@rstorey
Labels
bug Something isn't working
Projects
Sprint 19 Feb. 25 - Mar. 15

Comments

@rstorey
Copy link
Member

rstorey commented Mar 4, 2019

What behavior did you observe? Please describe the bug
500 error occurs.

How can we reproduce the bug?

  1. Add an item that has a . in the ID.
  2. Attempt to load the item in the admin pages or view it in the site as a regular user.

What is the expected behavior?
Should be able to function as a regular item

Additional context
https://crowd-sentry.loc.gov/loc/crowd-backend/issues/242
@rstorey rstorey added the bug Something isn't working label Mar 4, 2019
@rstorey rstorey self-assigned this Mar 4, 2019
rstorey added a commit that referenced this issue Mar 4, 2019
@rstorey
Allow item IDs to have periods in them, refs #836
968f521
@rstorey rstorey mentioned this issue Mar 4, 2019
Merged
@rstorey rstorey added this to To do in Sprint 19 Feb. 25 - Mar. 15 via automation Mar 4, 2019
@rstorey rstorey moved this from To do to Needs review in Sprint 19 Feb. 25 - Mar. 15 Mar 4, 2019
Sprint 19 Feb. 25 - Mar. 15 automation moved this from Needs review to Done Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstorey rstorey

Labels
bug Something isn't working
Projects
No open projects
Sprint 19 Feb. 25 - Mar. 15
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rstorey @elainekamlley