Allow item IDs to have periods in them #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
reviewed
Mar 4, 2019
concordia/urls.py
Outdated
| @@ -12,6 +12,7 @@ | |||
| from . import converters, views | |||
|
|
|||
| register_converter(converters.UnicodeSlugConverter, "uslug") | |||
| register_converter(converters.ItemSlugConverter, "islug") | |||
There was a problem hiding this comment.
I'd be included to give this a longer name since this is really saying that the value is something other than a slug. Maybe just go with item_id?
concordia/converters.py
Outdated
| @@ -5,3 +5,8 @@ class UnicodeSlugConverter(SlugConverter): | |||
| # This is similar to the slug_unicode_re pattern but is not anchored to the | |||
| # start of the string: | |||
| regex = r"[-\w+]+" | |||
|
|
|||
|
|
|||
| class ItemSlugConverter(SlugConverter): | |||
There was a problem hiding this comment.
Since this isn't really a slug any more, maybe it should just directly subclass StringConverter and be something like ItemIdConverter?
|
According to Patrick, any character that can be in a URL can be in an item ID (including slashes) - except for |
acdha
previously approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #836