-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add drag and drop for rails in editor :) #164
Conversation
Cursor is offset.
|
if you drag the endpoint onto the movement gizmo, you trigger the movement |
I would favor if you could change the addition behaviour to (but not a blocker and can be made in a follow-up PR):
|
ty for review
|
f53c750
to
bb40e63
Compare
9926d6f
to
eb7773d
Compare
I doesn't do anything after I press OK and instead get that error:
|
and when it starts to show the text box, it says:
|
Looks like you're triggering the complex connector, for arbitrary connections. That's not implemented yet, I guess I should have disabled the popup for it, but as it stands, this PR is WIP. Signal errors should be fixed with a simple if check. (though I kinda wish godot just wouldn't throw an error on double connect...) |
Yeah I figured the signals will be connected multiple times, because the snapping is in place, but the the popup connection logic is triggered every snapping mouse movement frame. That is totally fine. I was just super confused, but I found the two working use cases, so no worried there (although the complex one may be used even in the 90° case). |
eb7773d
to
e81ca29
Compare
e81ca29
to
41b2c8f
Compare
🥳 |
Fixed #151 😄
don't merge just yet, there might be some bugs.
we might want to add a minimum radius.