- Propose alternative solution for fix #1111, #1117 #1125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commit d0a0ef2 causes Compiler Error C2797 in Visual Studio
… reactivated - Right clicking with the mouse now exits the toolbar panning mode.
- Introduce "friendlyName" member to RS_Font; this is used as an alternate file name for font lookup
Closed
lordofbikes
requested changes
Jun 12, 2019
There was a problem hiding this comment.
All this initializer_list fuss is only needed for RS_Snapper::catchEntity() method:
LibreCAD/librecad/src/lib/actions/rs_snapper.h
Lines 156 to 157 in 10d502d
So I propose to put the typedef in rs_snapper.h and change the catchEntity() method accordingly.
I think this is more comprehensible than in rs_previewactioninterface.h.
Before I merge I'll also check this solution with gcc 9, which was the original cause for the fix.
This reverts commit c0f0aed.
- Reverse font changes from previous commit
…ked file -- (present save as dialog if the file is not writable) - Fixes a bug preventing Print Preview window from closing, except by closing it's parent window - Fixes a windows-specific file permission checking issue (enable support for NTFS security in Qt)
- Created a GUI for the ttf2lff font conversion tool - Added a button to the Application Options to launch the font conversion dialog
- Add the new "Convert Fonts" button to Text and MText dialogs - Add "fontFamily" property to RS_Font - Fixed zoom panning bug which prevented the cursor from being reset
…s from LibreCAD to PN/PNLT Part List/Part Bin
# Conflicts: # librecad/src/main/qc_applicationwindow.cpp # librecad/src/main/qc_applicationwindow.h
- another case of MSVC not liking std::initialializer_list(s): changed type to QList
…the mouse cursor, instead of the linear distance.
# Conflicts: # librecad/res/icons/icons.qrc # librecad/src/custom.pro
- Added a Shift-select mode to the default action - Add previews to all mouse-pick-select modes
…ry/LibreCAD into feature/ExportToProNest
…ed exe installer.
…nstaller or something else, we will need to make some pretty sweeping changes throughout the build pipeline.
Feature/build with jenkins
PN-2118 LibreCAD Help should display topic for the current User Mode LibreCAD Installer should install .NET Framework 4.6.2 in order to successfully register Telemetry.dll when installed as stand-alone
- Always use Windows file path separators when Exporting to ProNest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sounds like this type of implicit array initialization was leading to bad code generation by the compiler, causing linking errors; and so they now flag this as an error. Given the other reports, I suspect these other compilers are having similar problems, but it's not being caught.