Helper, shortcut & bug correction for "Circle with center & radius" tool #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help tip : when in mode "circle with center and radius", typing "radius" in the command-line allow the user to set the radius without moving hands off the keyboard, but the helper message didn't mentionned that possibility. Bug : when setting radius from commandline, pressing enter to validate causes LibreCAD to draw a circle of selected radius at relative zero position (if no mouse activity into the container) or crosshair position (if mouse activity into the container). I added a `switch` test to the `trigger()` method to test the mode, and if the user is in mode "SetRadius", circle is not drawn & relative zero is not moved. Command shortcuts: `circlecr` and `cc` Conflicts: librecad/src/cmd/rs_commands.cpp
jerry-magnin
force-pushed
the
master
branch
from
f28f647
to
684ab78
Compare
|
Thanks! |
dxli
added a commit
that referenced
this pull request
Sep 16, 2015
Helper, shortcut & bug correction for "Circle with center & radius" tool
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help tip
When in mode "circle with center and radius", typing "radius"
in the command-line allow the user to set the radius without moving
hands off the keyboard, but the helper message didn't mentionned that
possibility.
Bug
When setting radius from commandline, pressing enter to validate
causes LibreCAD to draw a circle of selected radius at relative zero
position (if no mouse activity into the container) or crosshair
position (if mouse activity into the container).
I added a
switchtest to thetrigger()method to test the mode, andif the user is in mode "SetRadius", circle is not drawn & relative zero
is not moved.
Command shortcuts
circlecrandcc