Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netbase: initial package #1518

Merged
merged 2 commits into from
Apr 18, 2017
Merged

netbase: initial package #1518

merged 2 commits into from
Apr 18, 2017

Conversation

CvH
Copy link
Member

@CvH CvH commented Apr 9, 2017

current iana version version is from 2008
protocols is 25kb
services 750kb

new version is from ubuntu 17.04 release (if it is good enough for ubuntu ...)
protocols is 3kb
services 19kb

changed package to netbase

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Apr 9, 2017

Not sure I'm qualified to approve this, to be honest. Ping @lrusak?

What about https://github.com/Mic92/iana-etc as a source, as used by NixOS?

Edit: OK that Mic92 source might be something else completely... a bunch of scripts.

@CvH
Copy link
Member Author

CvH commented Apr 9, 2017

@MilhouseVH pure guess for review ;)
Mic92/iana-etc is 20x in size (even its "just" kb), same for amylum/iana-etc

The ubuntu one was the smallest i could find. It is good enough for ubuntu server so I guess it is safe to assume that it is good enough for us too.

@MilhouseVH
Copy link
Contributor

OK I'll add this to tonight's test builds (along with the tz bump)

@vpeter4
Copy link
Contributor

vpeter4 commented Apr 10, 2017

What about preparing it from direct source like arch is doing? link
And having mkpkg_iana_etc script.

@CvH
Copy link
Member Author

CvH commented Apr 10, 2017

@vpeter4 this is 20x the size of the ubuntu one, ofc I would prefer some direct source - but I haven't found it for Ubuntu or other OS that offers an "small" version of the file.

@vpeter4
Copy link
Contributor

vpeter4 commented Apr 10, 2017

Then why not use directly file http://archive.ubuntu.com/ubuntu/pool/main/n/netbase/netbase_5.4.tar.xz and avoid repacking.

@CvH
Copy link
Member Author

CvH commented Apr 10, 2017

@vpeter4 tx fixed :)

@stefansaraev
Copy link
Contributor

what about renaming the package from iana-etc to netbase /me runs

@CvH
Copy link
Member Author

CvH commented Apr 10, 2017

@stefansaraev I thought the same, but "netbase.zip" includes basically the iana db + some debian magic ... I am really lost what is the best way to go here - if noone has a preference I keep the current.

@vpeter4
Copy link
Contributor

vpeter4 commented Apr 10, 2017

I think @stefansaraev mentioned above because of this :)

@lrusak
Copy link
Member

lrusak commented Apr 14, 2017

I would just do it like seo has it.

@CvH CvH changed the title iana-etc: update to 17.04 netbase: initial package Apr 15, 2017
@CvH CvH force-pushed the cleanup_iana branch 2 times, most recently from 0cb48fa to e34f7a4 Compare April 15, 2017 14:03
@CvH
Copy link
Member Author

CvH commented Apr 15, 2017

updated to netbase

@MilhouseVH
Copy link
Contributor

Looks good (contents of netbase is identical to iana-etc). Let's test build it for a couple more days to be sure.

@stefansaraev
Copy link
Contributor

the rpcbind sed hack feels like hack ;)

if rpcbind is not assigned that means some ugly userspace is doing the wrong thing (or it did in the past, but not anymore, who knows). you should drop that hack /me runs ;)

@CvH
Copy link
Member Author

CvH commented Apr 17, 2017

@stefansaraev are you confident that it breaks nothing we should care about ?
After your comment I googled a bit and found some relation with transmission - maybe this was a fix tm long time ago.

The commit message for this "fix" is useless 4640084 so I didn't opened pandora's box :)

@HiassofT
Copy link
Member

I also vote for dropping "fix" - use the file as it's in Debian and Ubuntu.

BTW: and I'd also suggest sourcing the package from Debian (like @stefansaraev does), as that seems to be the original source - Ubuntu's .dsc is referring to Debian's git :)
http://archive.ubuntu.com/ubuntu/pool/main/n/netbase/netbase_5.4.dsc

@stefansaraev
Copy link
Contributor

stefansaraev commented Apr 17, 2017

I am pretty sure it breaks nothing. or the same thing would appear broken on all other linux distributions :)

if you can mount nfs shares via ssh using busybox mount - all good (isn't that the only purpose of the rpcbind daemon in LE), if not - there is something wrong somewhere else happening.

EDIT: and no, transmission is unrelated, no matter what you found on the nets

EDIT: even if you completely remove etc/services and etc/protocols, everything should work perfectly fine if you ask me, I am not aware of any sane userspace program / daemon that relies on services / protocols for it's normal operation. not counting the case where user chooses to do "telnet x.x.x.x ftp" instead of "telnet x.x.x.x 21" ;)

@CvH
Copy link
Member Author

CvH commented Apr 17, 2017

dropped "fix" and changed to debian
@stefansaraev tx for clarification
@HiassofT changed to debian (ubuntu has the hash identical archive)

@MilhouseVH MilhouseVH merged commit f7ee67a into LibreELEC:master Apr 18, 2017
@CvH CvH deleted the cleanup_iana branch April 18, 2017 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants