-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Project Staging #164
Conversation
You have packages in the You're commit messages don't match our styling. Overall I don't agree with this. The create_virtualimage script we ship should be more than enough for users to create their own disk image. When providing pre built images you will be locked to using one size. It's just not worth it in my opinion. |
I can move projects/$PROJECT/packages to $ROOT/packages of course.
Please explain. I don't agree with create_virtualimage. I found it did almost exactly what mkimage was already doing, except it had to be run as root and required more dependencies to be installed on the host system. The end-user can always re-size their disk image on their own so they are not locked to using one size afaik. In vmware this is expanding and vboxmanage can resize vdi's. |
commit styling examples
Sure, if you want to do it then go for it I won't block it. Just be aware that the virtual project is _not_ aimed at users, it is aimed at developers for testing. If users need to use virtualization then they should use the Generic project in KVM. |
24756f9
to
375a2f2
Compare
I've cleaned up the cosmetics of the commits including messages, some squashing, and some splitting. |
a617ae5
to
e2d6783
Compare
I've dropped the ovftool requirements from this PR thereby removing any need to deal with VMware licensing and packaging issues. I'm still working on getting the ova manifest to work properly and I've left my commit regarding that off the last push. Dropping ovftool made the virtual package rather redundant, but I don't know which is preferred: |
2fd94af
to
72073bd
Compare
Yes, this should be good to merge. |
Recently the "es1371" audio driver stopped working correctly (vmware). Switching to "hdaudio" solved this problem. It was suggested to move the default Ethernet setup type from NAT to bridged. I've done this as well. A recent OVA with these changes can be found Here, however this OVA does not have any Virtualbox support in it because I cut it out when building for my testing purposes. |
For historical reference we ideally want guestOS = "other3xlinux-64" rather than "Ubuntu 64-Bit" but the reference code currently eludes us. I personally have no problems with not having Virtualbox OVA support since currently Virtualbox does not work well anyway (an ongoing trend for Virtualbox). The inclusion of working sound and the trivial VMWare install are big steps for developers. Running here with no issues. Recommend pulling ASAP so it can be tested as part of the current Alpha cycle. |
655d168
to
33c7061
Compare
Latest changes are squashed up. Got this down the minimal commits. Good to merge. |
This is a placeholder PR until this is cleaned up and finalized.
We are trying to make VMware and Virtualbox images during the regular
make image
process. They should be generic enough to "just work" for use and be sane enough to handle both older versions of VB, or VMware.Current status:
VMware
Virtualbox
vboxmanage clonehd $image.vmdk $image.vdi ; vboxmanage modifyhd $image.vdi --resize $size_in_mb
: user can then attach the newly expanded vdi to their vm.