Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Project Staging #164

Merged
merged 8 commits into from
Aug 1, 2016
Merged

Virtual Project Staging #164

merged 8 commits into from
Aug 1, 2016

Conversation

zalaare
Copy link
Contributor

@zalaare zalaare commented Apr 15, 2016

This is a placeholder PR until this is cleaned up and finalized.

We are trying to make VMware and Virtualbox images during the regular make image process. They should be generic enough to "just work" for use and be sane enough to handle both older versions of VB, or VMware.

Current status:

VMware

  • Import .ova file works as expected.
  • vmdk needs to be physically expanded by the user prior to booting for the first time or the storage partition will continue to stay the 32MB (which may be fine for the user).
    • If PR#205 is used in conjunction, then user can resize disk at any point, then use the Reset LE to defaults option.
  • sound is working now

Virtualbox

  • Import .ova file works as expected.
  • image uses vmdk, so if the user wants to expand the disk, they will have to:
    vboxmanage clonehd $image.vmdk $image.vdi ; vboxmanage modifyhd $image.vdi --resize $size_in_mb : user can then attach the newly expanded vdi to their vm.
    • If PR#205 is used in conjunction, then user can resize disk at any point, then use the Reset LE to defaults option.

@lrusak
Copy link
Member

lrusak commented Apr 15, 2016

You have packages in the project/ dirs, please move them.

You're commit messages don't match our styling.

Overall I don't agree with this. The create_virtualimage script we ship should be more than enough for users to create their own disk image. When providing pre built images you will be locked to using one size. It's just not worth it in my opinion.

@zalaare
Copy link
Contributor Author

zalaare commented Apr 15, 2016

I can move projects/$PROJECT/packages to $ROOT/packages of course.

You're commit messages don't match our styling.

Please explain.

I don't agree with create_virtualimage. I found it did almost exactly what mkimage was already doing, except it had to be run as root and required more dependencies to be installed on the host system. The end-user can always re-size their disk image on their own so they are not locked to using one size afaik. In vmware this is expanding and vboxmanage can resize vdi's.

@lrusak
Copy link
Member

lrusak commented Apr 15, 2016

commit styling examples

qemu: add initial package
linux.x86_64.conf: add ensoniq es1371 sound card support

Sure, if you want to do it then go for it I won't block it. Just be aware that the virtual project is _not_ aimed at users, it is aimed at developers for testing. If users need to use virtualization then they should use the Generic project in KVM.

@zalaare zalaare force-pushed the Virtual-Staging branch 3 times, most recently from 24756f9 to 375a2f2 Compare April 15, 2016 18:52
@zalaare
Copy link
Contributor Author

zalaare commented Apr 15, 2016

I've cleaned up the cosmetics of the commits including messages, some squashing, and some splitting.

@zalaare zalaare force-pushed the Virtual-Staging branch 2 times, most recently from a617ae5 to e2d6783 Compare April 19, 2016 15:41
@zalaare
Copy link
Contributor Author

zalaare commented Apr 19, 2016

I've dropped the ovftool requirements from this PR thereby removing any need to deal with VMware licensing and packaging issues. I'm still working on getting the ova manifest to work properly and I've left my commit regarding that off the last push.

Dropping ovftool made the virtual package rather redundant, but I don't know which is preferred:
[ "$PROJECT" = Virtual ] && $SCRIPTS/install qemu:host
[ "$PROJECT" = Virtual ] && $SCRIPTS/install virtual
I left it with the latter though virtual only installs qemu:host at this time.

@CvH
Copy link
Member

CvH commented Jul 16, 2016

@zalaare good to merge ? If no complains from @lrusak pls merge :)

@zalaare
Copy link
Contributor Author

zalaare commented Jul 18, 2016

Yes, this should be good to merge.

@zalaare
Copy link
Contributor Author

zalaare commented Jul 27, 2016

Recently the "es1371" audio driver stopped working correctly (vmware). Switching to "hdaudio" solved this problem.

It was suggested to move the default Ethernet setup type from NAT to bridged. I've done this as well.

A recent OVA with these changes can be found Here, however this OVA does not have any Virtualbox support in it because I cut it out when building for my testing purposes.

@nomandera
Copy link
Contributor

nomandera commented Jul 29, 2016

For historical reference we ideally want guestOS = "other3xlinux-64" rather than "Ubuntu 64-Bit" but the reference code currently eludes us.

I personally have no problems with not having Virtualbox OVA support since currently Virtualbox does not work well anyway (an ongoing trend for Virtualbox). The inclusion of working sound and the trivial VMWare install are big steps for developers.

Running here with no issues. Recommend pulling ASAP so it can be tested as part of the current Alpha cycle.

@zalaare
Copy link
Contributor Author

zalaare commented Aug 1, 2016

Latest changes are squashed up. Got this down the minimal commits. Good to merge.

@CvH CvH merged commit 6d29350 into LibreELEC:master Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants