-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce $DEVICE complexity #1778
Conversation
No objection to this change in principal, but it could be simplified to:
The Just a matter of style/preference, really. |
I like the |
I made a small adjustment and defined |
89283e8
to
fbc4fd4
Compare
Squashed and updated to use the |
Looks good to me, @lrusak any concerns? |
Might also be worth backporting this to libreelec-8.2? |
This PR adds support to use $DEVICE in shell version output and also changes to use same formatting as in the settings addon (
<device/project>.<arch>
)Before:
After: