Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nss/nspr: include in main image [rfc] #1791

Merged
merged 5 commits into from
Nov 1, 2017
Merged

nss/nspr: include in main image [rfc] #1791

merged 5 commits into from
Nov 1, 2017

Conversation

MilhouseVH
Copy link
Contributor

This builds nss and nspr as part of the main image, for x86. The packages are based on the existing add versions (which are now removed), but bumped to latest versions (thanks @InuSasha).

The libraries created by nss and nspr are required by chromium and inputstream.adaptive addons (in the case of the latter, they're required by libwidevinecdm.so).

This PR adds nss as a dependency of kodi, when building for x86_64. It also builds nss using the system Sqlite3 library which avoids nss installing a version of libsqlite3.so that can't be linked by kodi (and thus causing Kodi to fail).

The additional libraries add about 4MB to the final SYSTEM size.

There may be better ways of doing this, perhaps a dedicated nss/nspr addon, if anyone wants to have a go at that.

@InuSasha
Copy link
Member

If chromium depends on nss, nss should continue to be in TARGET_DEPENDS.
sqlite should add to dependencies of nss.

alternative solution: nss/nspr as single addon. chromium and inputstream.adaptive can depend on it. But the linking will get... meh, i think

definitely +1³ to build nss on system sqlite

@Ray-future
Copy link
Contributor

Newer versions of widevine for ARM depend on nss/nspr too not only x86.

@Ray-future
Copy link
Contributor

I've been testing script.module.inputstreamhelper on arm.
It's working good but it's failing for missing libnss. To build nss on arm I needed 2 patches: Ray-future@7ac0431
Not sure it is a proper solution but I'd really like to have that on ARM too especially if xbmc/repo-scripts#607 gets merged.

@asciidisco provided a branch for NF testing: https://github.com/asciidisco/plugin.video.netflix/tree/feat/add-inputstream-helper

@sopparus
Copy link
Contributor

if there is a 8.2.4 I think this should be backported, widewine wont work without it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants