-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nss/nspr: include in main image [rfc] #1791
Conversation
If chromium depends on nss, nss should continue to be in TARGET_DEPENDS. alternative solution: nss/nspr as single addon. chromium and inputstream.adaptive can depend on it. But the linking will get... meh, i think definitely +1³ to build nss on system sqlite |
Newer versions of widevine for ARM depend on nss/nspr too not only x86. |
I've been testing script.module.inputstreamhelper on arm. @asciidisco provided a branch for NF testing: https://github.com/asciidisco/plugin.video.netflix/tree/feat/add-inputstream-helper |
set NSS_USE_SYSTEM_SQLITE Signed-off-by: Radostan Riedel <raybuntu@googlemail.com>
Add nss dependency for x86 and arm to virtual/network.
if there is a 8.2.4 I think this should be backported, widewine wont work without it :( |
This builds nss and nspr as part of the main image, for x86. The packages are based on the existing add versions (which are now removed), but bumped to latest versions (thanks @InuSasha).
The libraries created by
nss
andnspr
are required bychromium
andinputstream.adaptive
addons (in the case of the latter, they're required bylibwidevinecdm.so
).This PR adds
nss
as a dependency of kodi, when building for x86_64. It also buildsnss
using the system Sqlite3 library which avoidsnss
installing a version oflibsqlite3.so
that can't be linked by kodi (and thus causing Kodi to fail).The additional libraries add about 4MB to the final SYSTEM size.
There may be better ways of doing this, perhaps a dedicated
nss
/nspr
addon, if anyone wants to have a go at that.