Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Season Games are not working just Highlights #86

Open
elschmidtorado opened this issue Oct 10, 2018 · 24 comments
Open

Pre-Season Games are not working just Highlights #86

elschmidtorado opened this issue Oct 10, 2018 · 24 comments

Comments

@elschmidtorado
Copy link

Hi there,

i am not sure, if anybody has already opened an issue about the actual problem.....

I use Kodi (LibreElec, not Leia) and after the changes in April 2018 everything worked fine for me. But actual with the Pre-Season Games the plugin isnt workin..... just for the highlights. :-(

Should i try Leia or is it another problem and we need a new release??????

thx and i appreciate your work so much.

@akulagr
Copy link

akulagr commented Oct 10, 2018

I've tried with libreelec 17.6 but as you said only highlights play and with really poor quality. I also tried with kodi 18 on android but nothing works on that, I only get sound and no image from game replays.
The changes in stream format have made it difficult to get it working again.

It's a shame, because the add-on was really good quality.

@Elschnuppero
Copy link

Jep, same issue here :(

@elschmidtorado
Copy link
Author

So the First Games of the New season are online, but the App is not workin. Is there anyone there to fix it?

@akulagr
Copy link

akulagr commented Oct 18, 2018

The add-on works for me on Kodi 18 (beta 3 x64) for windows. I think there's no way to make it work on Android or libreelec at the moment.

At least I can plug my laptop to the tv and watch games that way. Kodi is way better than the browser.

@elschmidtorado
Copy link
Author

i tried the newest nightly kodi 18 and its the same on windows, if you choose your Gameview short Playbutton on the top right than it pops back to the menu...... :-(

@ivankokan
Copy link
Contributor

ivankokan commented Oct 20, 2018

Let me just inform you (especially @maxgalbu) that everything is working with this setup on Windows (fresh install of everything): nightly Kodi build (KodiSetup-20181010-e78d2d41-master-x64) + April 10 release (https://github.com/maxgalbu/xbmc.plugin.video.nba/releases) + auto Widevine installation + video quality set to 720p (6000 kbps). Started to watch (regular season, live) GSW@UTA at the halftime, now it's end of Q3.

@tent-icle
Copy link

tent-icle commented Oct 23, 2018

I finally subscribed for the new season, so I was able to take a quick look at this.

Running Kodi 17.6 on armv7l (imx6), the ffmpeg debug logs show the following for archived full games (but not for archived condensed games, which play just fine):

05:07:17.499 T:919597984 DEBUG: ffmpeg[36CFF3A0]: [hls,applehttp] HLS request for url 'https://nbanlds245vod.akamaized.net/nlds_vod/nba/vod/2018/10/20/drm/n lncp/21800035/2f30fe10-5d26-3de3-eb85-0024d05c25c8/v1/stream/2_21800035_hou_lal_2018_b_whole_1_6000_000000.ts', offset 0, playlist 0
05:07:17.499 T:919597984 ERROR: ffmpeg[36CFF3A0]: [hls,applehttp] SAMPLE-AES encryption is not supported yet
05:07:17.499 T:919597984 DEBUG: ffmpeg[36CFF3A0]: [hls,applehttp] Failed to open segment of playlist 0

Yuck. HLS SAMPLE-AES is a bit of a half-assed encryption scheme, but it just so happens ffmpeg is not currently able to decrypt it, whereas - as far as I can tell - ffmpeg can decrypt the (more comprehensive) HLS AES-128 scheme. Most likely, Neulion (or whomever is running things now) have chosen SAMPLE-AES because the overhead of AES-128 is too high for mobile devices. However, a cynic might suggest they have chosen it to be deliberately obscure...

I am not clear how this can be working on the Kodi x64 nightly, as reported by @ivankokan above. Is there a wrapper HLS decoder implemented there?

(Unfortunately, Kodi 18 is temporarily dropping imx6 support, so that makes testing any fix in the nightlies much more difficult for me).

@ivankokan
Copy link
Contributor

ivankokan commented Oct 23, 2018

It's all about DRM encryption so Kodi 18 is mandatory: #76. Pretty much discussed at the end of the last season.

@tent-icle
Copy link

tent-icle commented Oct 23, 2018

That change late last season was the move to Widevine for inputstream.adaptive - which worked fine on Kodi 17.6 once @mkorganashvili 's plugin changes were merged

@elschmidtorado
Copy link
Author

So i flashed a Kodi 18 Leia Beta3 image LibreElec release for my Mini II M8s S905X Chip Android Box and installed the latest NBA Addon from 10. April 2018. Input Stream Adaptive activated manually, set 720p resolution installed widewine from ChromeOS automatic , reboot the box and....... ### it works!!!!!!!

@tent-icle
Copy link

tent-icle commented Oct 23, 2018

Okay, I built a new x86_64 VM running Win10 and installed the latest Kodi nightly (KodiSetup-20181023-c77874c5-master-x64.exe). I'm sorry to say this produces exactly the same result as 17.6 on arm: archived condensed games play correctly, archived full games fail - brief Windows log extra as follows:

03:59:50.480 T:7388 DEBUG: ffmpeg[1CDC]: [hls,applehttp] HLS request for url 'https://nbanlds245vod.akamaized.net/nlds_vod/nba/vod/2018/10/17/drm/nlncp/21800006/fc4f53c0-5d25-3de3-eb85-0024d05c25c8/v1/stream/2_21800006_mia_orl_2018_b_whole_1_1600_000000.ts', offset 0, playlist 0
03:59:50.480 T:7388 ERROR: ffmpeg[1CDC]: [hls,applehttp] SAMPLE-AES encryption is not supported yet
03:59:50.480 T:7388 DEBUG: ffmpeg[1CDC]: [hls,applehttp] Failed to open segment 0 of playlist 0

@akulagr and @ivankokan, were there any other configuration changes you needed to make? At this stage, the behavior on nightly/x64/Windows does not appear any different to 17.6/arm/Linux. I am struggling to reproduce your results.

@akulagr
Copy link

akulagr commented Oct 23, 2018

@tent-icle I can't think of anything specific that I did to get working on win10.
Used the beta 3 available from kodi ( pre-release installer, not nightly) used the latest zip available on github.
Enabled inputstream, then installed the add-on which in turn proceeded to download and install widevine. Tested and it's been working ever since (both live and full replays)

Sorry i can't be of any more help.

Now im trying to at least make it work with libreelec on a very old android box (m8s plus) but no luck so far.

@elschmidtorado
Copy link
Author

@akulagr

you have to use that image that i've taken i looking for the link......
[(https://forum.libreelec.tv/thread/12155-libreelec-8-90-x-kodi-18-for-minix-x8-x8h-x8hplus-mx3-g-plus-and-s905-x-d-w/)]
With this Image it works for me on my MINI M8S II

thx a lot

i bought a fucking appleTV3 - what a crap

@akulagr
Copy link

akulagr commented Oct 23, 2018

@elschmidtorado
Thanks for the link. Unfortunately that wont work for me since I got an amlogic s812. Might have to give up with libreelec and just use Windows for now.

@ivankokan
Copy link
Contributor

ivankokan commented Oct 23, 2018

@akulagr and @ivankokan, were there any other configuration changes you needed to make? At this stage, the behavior on nightly/x64/Windows does not appear any different to 17.6/arm/Linux. I am struggling to reproduce your results.

Let me think again... Let me just inform you (especially @maxgalbu) that everything is working with this setup on Windows (fresh install of everything): nightly Kodi build (KodiSetup-20181010-e78d2d41-master-x64) + April 10 release (https://github.com/maxgalbu/xbmc.plugin.video.nba/releases) + Install Add-on with ZIP file that prompts me to Allow Unknown sources + auto Widevine installation + Configure add-on settings with e-mail and password, of course including video quality set to 720p (6000 kbps). Started to watch (regular season, live) GSW@UTA at the halftime, now it's end of Q3, watched until the end of the game.

@Elschnuppero
Copy link

Let me think again... Let me just inform you (especially @maxgalbu) that everything is working with this setup on Windows (fresh install of everything): nightly Kodi build (KodiSetup-20181010-e78d2d41-master-x64) + April 10 release (https://github.com/maxgalbu/xbmc.plugin.video.nba/releases) + Install Add-on with ZIP file that prompts me to Allow Unknown sources + auto Widevine installation + Configure add-on settings with e-mail and password, of course including video quality set to 720p (6000 kbps). Started to watch (regular season, live) GSW@UTA at the halftime, now it's end of Q3, watched until the end of the game.

This is working on libreelec alpha (last version). Key is to install the nba addon manually per zip file. Thx

@tent-icle
Copy link

tent-icle commented Oct 24, 2018

Okay. I can confirm what others have said: no changes to the plugin are required to get this working. I have it running on x64 and two ARM platforms (imx6 and a borrowed rpi) now. Thank you to everyone here for your advice and assistance.

The issue is that inputstreamhelper installs a ‘legacy’ version (7834) of the Widevine CDM on Kodi 17. Version 10895 is needed for SAMPLE-AES decryption, however this version has a dependency on Mozilla’s nss3/nspr4 libs, which are not included in LibreElec 8.x - and is why inputstreamhelper does not install 10895 on that platform.

I manually cherry picked the patches from LibreELEC/LibreELEC.tv#1791 and compiled the nss/nspr libraries for Kodi 17.6 myself. Full games now play correctly. I wouldn’t recommend this path for most users but it was required in my case because imx6 does not yet support Kodi 18.

@Weed233
Copy link

Weed233 commented Dec 3, 2018

Hi. I had same problem but ivankokan solution worked

My problem for now is that quality for live or archieved games is bad
I don't know why because i set maximum quality.
Works fine for highlists/condensed games

also this problem only exists on windowed option. All types works good on full screen but on windowed only highlists/condensed games are in good quality

@ivankokan
Copy link
Contributor

@Weed233, follow the #89.

@ivankokan
Copy link
Contributor

@elschmidtorado This one can be closed, I guess.

@elschmidtorado
Copy link
Author

@ivankokan
yes i guess you can close this thread, but i have a new issue :-/

@ivankokan
Copy link
Contributor

@elschmidtorado I cannot close this one, you can. :)

@ivankokan
Copy link
Contributor

@elschmidtorado Please close this one.

1 similar comment
@ivankokan
Copy link
Contributor

@elschmidtorado Please close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants