use 7zip for addon.zip creation #1821
Conversation
scripts/create_addon
Outdated
| @@ -56,7 +56,7 @@ pack_addon() { | |||
| fi | |||
| cd $ADDON_BUILD | |||
| echo "*** compressing Addon $PKG_ADDON_ID ... ***" | |||
| zip -rq $PKG_ADDON_ID-$ADDONVER.zip $PKG_ADDON_ID; | |||
| $TOOLCHAIN/bin/7za a -l -mx9 -bsp0 -bso0 $PKG_ADDON_ID-$ADDONVER.zip $PKG_ADDON_ID; | |||
There was a problem hiding this comment.
Any special reason for ; character at the end of line?
Also why doesn't we store symbolic links as links? Is kodi even capable to extract them correctly? I think this could save space in some cases.
There was a problem hiding this comment.
Symbolic links save space indeed but Kodi can't handle them. It unpacks symlinks as regular files.
There was a problem hiding this comment.
But even in this case addon itself is smaller. Which is good.
Anyway, replacing zip with 7za seems ok to me.
There was a problem hiding this comment.
@vpeter4 Any special reason for ; character at the end of line?
it works with or without - the old version had it too, idk if it was some workaround or something (I can drop if you like)
There was a problem hiding this comment.
It is present from start as I can see. I think you should remove it :)
CvH
force-pushed
the
9.0-create_addon-7z
branch
from
2f3f16a
to
40979ee
Compare
|
updated pr, added |
CvH
force-pushed
the
9.0-create_addon-7z
branch
from
40979ee
to
6b5ebac
Compare
|
@MilhouseVH rebased |
|
Good, closing my pr. |
Use our own build 7z to create the addon.zip files.
We still use plain zip (kodi understands nothing else then very basic deflate) as archive.
Somehow 7zip does a better job at compressing zip files, we got an slight saving of 2-5% file size (more or less, depending of compressed addon).
It is not too much but the saving is for basically free.
opinions @kszaq @vpeter4 @MilhouseVH ?