Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rockchip: initial support #2116

Merged
merged 20 commits into from
Nov 2, 2017
Merged

Rockchip: initial support #2116

merged 20 commits into from
Nov 2, 2017

Conversation

Kwiboo
Copy link
Member

@Kwiboo Kwiboo commented Oct 15, 2017 •
edited
Loading

This PR adds initial support for Rockchip SoCs (video HW decoding not included).

This include commits from #2100 and #2108 and will be rebased once they have been merged into master.
There is also a temporary commit to fix a aarch64 build issue caused by pfcd_hevc_optimisations.patch that will be dropped once a proper solution is merged into master.

There are some issues to resolve / work on before this is ready to be merged:

  • Swtich to mainline u-boot and drop the project specific package
  • Drop the use of device specific mkimage scripts
  • LED control is no longer working using the latest RK 4.4 kernel
  • Update and combine linux patches
  • Possible WiFi issue on 64/32-bit build

Big thanks to @LongChair, @omegamoon, @Raybuntu and Rockchip engineers for great collaboration working on this.

@Kwiboo Kwiboo mentioned this pull request Oct 15, 2017
Closed
@LongChair
Copy link
Contributor

Awesome work @Kwiboo ! This has been a long time work :) also special thanks to @yanghanxing and his team for the great support he's been bringing us !

@Ray-future
Copy link
Contributor

Great job @Kwiboo!

CvH
CvH requested changes Oct 16, 2017
View reviewed changes
Copy link
Member

@CvH CvH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kwiboo nice work :) just so me small things that it follows our new standard :) Idk if you like to just do a followup commit that you don't need to touch every file + squash.

packages/graphics/mali-rockchip/package.mk Outdated
PKG_SHORTDESC="mali-rockchip: OpenGL ES user-space binary for the ARM Mali GPU family"
PKG_LONGDESC="mali-rockchip: OpenGL ES user-space binary for the ARM Mali GPU family"

PKG_IS_ADDON="no"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm PKG_IS_ADDON="no" and change to

PKG_SHORTDESC=""
PKG_LONGDESC=""
PKG_AUTORECONF="no"

packages/lang/gcc-linaro-aarch64-linux-gnu/package.mk Outdated
@@ -0,0 +1,41 @@
################################################################################
# This file is part of LibreELEC - https://libreelec.tv
# Copyright (C) 2016 Team LibreELEC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016-present

packages/lang/gcc-linaro-aarch64-linux-gnu/package.mk Outdated
PKG_LONGDESC=""

PKG_IS_ADDON="no"
PKG_AUTORECONF="no"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm PKG_IS_ADDON="no"

PKG_SHORTDESC=""
PKG_LONGDESC=""
PKG_AUTORECONF="no"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed those in my PR so a rebase should be sufficient :)

packages/multimedia/rkmpp/package.mk Outdated
PKG_LONGDESC="rkmpp: Rockchip Media Process Platform (MPP) module"

PKG_IS_ADDON="no"
PKG_AUTORECONF="no"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm PKG_IS_ADDON="no"

PKG_SHORTDESC=""
PKG_LONGDESC=""
PKG_AUTORECONF="no"

packages/multimedia/rkmpp/package.mk Outdated
PKG_AUTORECONF="no"

if [ "$UBOOT_SOC" = "rk3328" ]; then
ENABLE_VP9D="ON"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENABLE_VP9D should be PKG_ENABLE_VP9D as we try to rework every custome var to PKG_... (same change DENABLE_VP9D=$ENABLE_VP9D)

projects/Rockchip/devices/ROCK64/scripts/mkimage Outdated
@@ -0,0 +1,48 @@
################################################################################
# This file is part of LibreELEC - https://LibreELEC.tv
# Copyright (C) 2017 Team LibreELEC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017-present

projects/Rockchip/devices/TinkerBoard/scripts/mkimage Outdated
@@ -0,0 +1,40 @@
################################################################################
# This file is part of LibreELEC - https://LibreELEC.tv
# Copyright (C) 2017 Team LibreELEC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017-present

projects/Rockchip/devices/TinkerBoard/scripts/mkimage Outdated
@@ -0,0 +1,40 @@
################################################################################
# This file is part of LibreELEC - https://LibreELEC.tv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://libreelec.tv

projects/Rockchip/packages/rtl8723b_bt/package.mk Outdated
################################################################################

PKG_NAME="rtl8723b_bt"
PKG_VERSION=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls gave it some version or we get 0.0invaild instead

projects/Rockchip/packages/rtl8723b_bt/package.mk Outdated
PKG_LONGDESC="rtl8723b_bt firmware"

PKG_IS_ADDON="no"
PKG_AUTORECONF="no"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm PKG_IS_ADDON="no" and change to

PKG_SHORTDESC=""
PKG_LONGDESC=""
PKG_AUTORECONF="no"

@Kwiboo
Copy link
Member Author

Kwiboo commented Oct 16, 2017 •
edited
Loading

Rebased on latest master and updated #2100 commits, fixes for @CvH's comments have been squashed.
Also dropped a commit no longer needed after a small update to the device specific mkimage scripts.

Ray-future
Ray-future reviewed Oct 17, 2017
View reviewed changes
Copy link
Contributor

@Ray-future Ray-future left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop that commit too next time you rebase. See #2121

@Kwiboo Kwiboo force-pushed the rockchip-part1 branch 3 times, most recently from 601c6e4 to 92f993c Compare October 19, 2017 20:19
@CGarces CGarces mentioned this pull request Oct 24, 2017
Merged
@Kwiboo Kwiboo force-pushed the rockchip-part1 branch 4 times, most recently from cad050b to c125044 Compare November 1, 2017 21:44
@Kwiboo
Copy link
Member Author

Kwiboo commented Nov 1, 2017

Updated to latest RK 4.4 kernel, u-boot v2017.11-rc3 and linux patches is now merged files matching my linux-rockchip topic branches.

This should be ready to merge after a final boot test of new clean builds.

@Kwiboo
Copy link
Member Author

Kwiboo commented Nov 2, 2017

Clean builds boots and starts kodi, test images:

LibreELEC-ROCK64.aarch64-9.0-devel-20171102001520-r27249-g4f038a0.img.gz
LibreELEC-ROCK64.arm-9.0-devel-20171102034700-r27249-g4f038a0.img.gz
LibreELEC-TinkerBoard.arm-9.0-devel-20171102020010-r27249-g4f038a0.img.gz

@Ray-future Ray-future merged commit 86bc850 into LibreELEC:rockchip Nov 2, 2017
@Kwiboo
Copy link
Member Author

Kwiboo commented Nov 2, 2017

Thanks! 👍

@Kwiboo Kwiboo deleted the rockchip-part1 branch November 2, 2017 11:39
@chewitt
Copy link
Member

chewitt commented Nov 2, 2017

@Kwiboo nice work! .. and big thanks to all the others that helped move this forwards :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvH CvH CvH requested changes

@Ray-future Ray-future Ray-future approved these changes

Assignees
No one assigned
Labels
ROCKCHIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kwiboo @LongChair @Ray-future @chewitt @CvH