Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package gcc-linaro-aarch64-linux-gnu #2100

Merged
merged 2 commits into from
Oct 30, 2017

Conversation

Ray-future
Copy link
Contributor

@Ray-future Ray-future commented Oct 13, 2017

New package gcc-linaro-aarch64-linux-gnu that will be used to build kernel packages when doing 64/32bit builds.
Moving gcc-linaro-aarch64-elf and gcc-linaro-arm-eabi to projects/Odroid_C2.

It will require some testing so please don't merge right away. @Kwiboo can you try building your Rockchip projects with gcc-linaro-aarch64-linux-gnu 7.1?
@lrusak As discussed on Slack this might fix your dragonboard issues, thanks for the idea.

@Ray-future Ray-future force-pushed the linarobump branch 2 times, most recently from dcb4397 to 18b7ab1 Compare October 13, 2017 15:38
@Ray-future
Copy link
Contributor Author

I'm moving gcc-linaro-arm-eabi to projects too cause it's only used by Odroid_C2.

@Ray-future Ray-future changed the title gcc-linaro-aarch64-elf: Update to 7.1.1-2017.08 New package gcc-linaro-aarch64-linux-gnu Oct 13, 2017
@lrusak
Copy link
Member

lrusak commented Oct 13, 2017

thanks @Raybuntu !!!

@Ray-future
Copy link
Contributor Author

I've made 3 clean ARM builds with this PR over night for C2, WH and WP2. It's building without issues and a quick test on WH and WP2 was ok too.

Copy link
Member

@Kwiboo Kwiboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great with a clean build of Rockchip ROCK64.arm.
Compile and basic run tested (together with the rtl8812au module loaded).

@Ray-future
Copy link
Contributor Author

Thanks @Kwiboo

@Ray-future
Copy link
Contributor Author

Please do not merge yet. There is a small issue with 64/32bit when building u-boot or linux before starting a complete build. cmake.conf will be wrong. That issue is not introduced by this PR but I wanna include a fix with this PR to catch 2 birds with one stone.

@Kwiboo Kwiboo mentioned this pull request Oct 15, 2017
5 tasks
PKG_SHORTDESC=""
PKG_LONGDESC=""

PKG_IS_ADDON="no"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four lines above can be dropped (see #2117). Also licence copyright should be updated. A shortdesc would be nice!

@Ray-future Ray-future force-pushed the linarobump branch 3 times, most recently from bd1a250 to 0265c5b Compare October 16, 2017 06:58
@Ray-future
Copy link
Contributor Author

@MilhouseVH Thanks for the review. I've applied everything and rebased.

PKG_SOURCE_DIR="gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu"
PKG_SECTION="lang"
PKG_AUTORECONF="no"
PKG_SHORTDESC="Linaro Aarch64 GNU Linux Binary Toolchain"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoreconf should be after shortdesc

Odroid_C2: move gcc-linaro-aarch64-elf to projects
Odroid_C2: move gcc-linaro-arm-eabi to projects
@Ray-future
Copy link
Contributor Author

@CvH Thanks. Fixed!

PKG_ARCH="any"
PKG_LICENSE="GPL"
PKG_SITE=""
PKG_URL="https://releases.linaro.org/components/toolchain/binaries/7.1-2017.08/aarch64-linux-gnu/gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu.tar.xz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-+PKG_URL="https://releases.linaro.org/components/toolchain/binaries/7.1-2017.08/aarch64-linux-gnu/gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu.tar.xz"
++PKG_URL="https://releases.linaro.org/components/toolchain/binaries/${PKG_VERSION}/aarch64-linux-gnu/gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu.tar.xz" 

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MilhouseVH unfortunately it's 7.1 not 7.1.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!

building just linux and starting a regular build later.
@Ray-future
Copy link
Contributor Author

Anything else? Nit picks? Merge?

@Kwiboo Kwiboo merged commit 9aae246 into LibreELEC:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants