-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package gcc-linaro-aarch64-linux-gnu #2100
Conversation
dcb4397
to
18b7ab1
Compare
I'm moving gcc-linaro-arm-eabi to projects too cause it's only used by Odroid_C2. |
18b7ab1
to
331f783
Compare
thanks @Raybuntu !!! |
I've made 3 clean ARM builds with this PR over night for C2, WH and WP2. It's building without issues and a quick test on WH and WP2 was ok too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great with a clean build of Rockchip ROCK64.arm.
Compile and basic run tested (together with the rtl8812au module loaded).
Thanks @Kwiboo |
Please do not merge yet. There is a small issue with 64/32bit when building u-boot or linux before starting a complete build. cmake.conf will be wrong. That issue is not introduced by this PR but I wanna include a fix with this PR to catch 2 birds with one stone. |
PKG_SHORTDESC="" | ||
PKG_LONGDESC="" | ||
|
||
PKG_IS_ADDON="no" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Four lines above can be dropped (see #2117). Also licence copyright should be updated. A shortdesc would be nice!
bd1a250
to
0265c5b
Compare
@MilhouseVH Thanks for the review. I've applied everything and rebased. |
PKG_SOURCE_DIR="gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu" | ||
PKG_SECTION="lang" | ||
PKG_AUTORECONF="no" | ||
PKG_SHORTDESC="Linaro Aarch64 GNU Linux Binary Toolchain" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autoreconf should be after shortdesc
Odroid_C2: move gcc-linaro-aarch64-elf to projects Odroid_C2: move gcc-linaro-arm-eabi to projects
0265c5b
to
be9aa11
Compare
@CvH Thanks. Fixed! |
PKG_ARCH="any" | ||
PKG_LICENSE="GPL" | ||
PKG_SITE="" | ||
PKG_URL="https://releases.linaro.org/components/toolchain/binaries/7.1-2017.08/aarch64-linux-gnu/gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-+PKG_URL="https://releases.linaro.org/components/toolchain/binaries/7.1-2017.08/aarch64-linux-gnu/gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu.tar.xz"
++PKG_URL="https://releases.linaro.org/components/toolchain/binaries/${PKG_VERSION}/aarch64-linux-gnu/gcc-linaro-${PKG_VERSION}-x86_64_aarch64-linux-gnu.tar.xz"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MilhouseVH unfortunately it's 7.1 not 7.1.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah!
be9aa11
to
236d9c8
Compare
building just linux and starting a regular build later.
236d9c8
to
66b316e
Compare
Anything else? Nit picks? Merge? |
New package gcc-linaro-aarch64-linux-gnu that will be used to build kernel packages when doing 64/32bit builds.
Moving gcc-linaro-aarch64-elf and gcc-linaro-arm-eabi to projects/Odroid_C2.
It will require some testing so please don't merge right away. @Kwiboo can you try building your Rockchip projects with gcc-linaro-aarch64-linux-gnu 7.1?
@lrusak As discussed on Slack this might fix your dragonboard issues, thanks for the idea.