multiple cosmetic fixes #2117
Merged
multiple cosmetic fixes #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilhouseVH
reviewed
Oct 15, 2017
| @@ -53,4 +53,4 @@ pre_configure_target() { | |||
|
|
|||
| make_target() { | |||
| : | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Can you restore the newline (which means the second hunk isn't necessary)
MilhouseVH
reviewed
Oct 15, 2017
| @@ -79,5 +78,4 @@ makeinstall_target() { | |||
| mkdir -p $SYSROOT_PREFIX/usr/lib/cmake/$PKG_NAME | |||
| cp $PKG_LIBPATH $SYSROOT_PREFIX/usr/lib/$PKG_LIBNAME | |||
| echo "set($PKG_LIBVAR $SYSROOT_PREFIX/usr/lib/$PKG_LIBNAME)" > $SYSROOT_PREFIX/usr/lib/cmake/$PKG_NAME/$PKG_NAME-config.cmake | |||
| } | |||
|
|
|||
| } | |||
|
This all looks very good so far - many thanks! |
|
fixed |
MilhouseVH
approved these changes
Oct 15, 2017
|
Many thanks @CvH! |
This was referenced Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pls don't look at the overall changes, single commits provide better overview
Would be nice if someone could have a second look about the changes.
Copyright (C) 2016 Team LibreELEC->Copyright (C) 2016-present Team LibreELEChttps://www.libreelec.tv&https://LibreELEC.tv->https://libreelec.tvPKG_USE_CMAKEPKG_IS_ADDON="no"and changed (to follow the overall standard)to
to