-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvb driver addons #2270
dvb driver addons #2270
Conversation
I did a quick build test of master+this PR and one thing I noticed is that the 4 driver addon packages for RPi2 added quite a lot of buildtime - especially when they were rebuilt. I took some measurements on my laptop (i5-3320M, SSD, 16GB RAM) and timed driver.dvb.crazycat build and as a comparison linux kernel build. Before each test I cleaned the package (scripts/clean ...) and dropped caches ( driver.dvb.crazycat build with .ccache removed took about 7 minutes, about half the time of a kernel build
Then, with ccache intact Ichecked the rebuild time - the crazycat driver rebuild took about 7 times (!) as long as the kernel rebuild:
Quite a lot of time in the crazycat build seems to be spent in the modpost stage - when @CvH could you check what's causing this? |
some more info, as discussed on slack -adding it here so it doesn't get lost: driver.dvb.hauppauge and driver.dvb.media_build download code from linuxtv.org during make_install - this should be changed to run through scripts/get. (re-)building media_build on master (i.e. without this PR) is also rather slow:
media_build on 8.2 doesn't seem to have this problem. A rebuild of media_build on another (rather slowish, ancient X3220 Xeon with spinning platter HDDs) buildbox only took about 1 minute:
|
@HiassofT added media_tree package, that package holds the media_tree that was downloaded before with that build in script at media_build, changed driver.dvb.media_build/hauppauge accordingly (idk why I didn't had this idea before as it is pretty simple solution 👍 ) |
26020cd
to
fdde57b
Compare
pushed changes:
currently nothing else planed if nobody has any objections |
034304e
to
460465a
Compare
I rebased your PR to my Amlogic S905/S912 builds for testing. It works, but I have a issue with internal dvb driver buit in crazycat package. I need it start after addon startup. In media_build version I use for starting internal driver following script system.d/amlogic-dvb.service:
Do you have any idea how to fix it? |
@afl1 try to add a dependency on the kernel overlay service - there are no kernel modules available before it's run
|
@HiassofT thanks, but I had bug in installing amlogic-dvb.service. Now it starts. |
@afl1 you can place the service in the project filesystem and it will be automatically enabled by the buildsystem |
This implements dvb drivers as add-ons. It is possible to use them at the repo or directly at the image.
Current PR adds them only direct at the image (like we done it at LE8.x).
driver.dvb
,driver.video
anddriver.net
, just add them and the add-on made them available regardless if at image or installed manually ( @escalade ideas for more subsystems to support?) - it is possible to create an add-on to support an older/newer gpu driver or add just another realtek fork etc for community builders without changing the base image-config/functions: add function install_driver_add-on_files_old
adds support to do it via repositories too (RFC if we want to support it at the build system - regardless if we use it or not)WIP things to know:
I added all add-ons that are currently possible - it makes no sense to include them all, but I can't really tell at the moment which one are useful or not at LE9.0 release (heavily depends at upstream)currently I tend to:generic: crazycat + digital_devices (as it is tiny) + hauppauge
everything else: crazycat + hauppauge
make all
testimage:
LE-Generic-9.0-27.11.2017-devel.tar (works at VM too)
how it works at LE:
demo video how it works
sidenote:
If "we" redo the LE-settings add-on some day, the driver choose script function could be included there, currently nobody likes to touch the LE settings add-on code at all and I really dislike to increase the mess at the current settings add-on even more.