Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media_build: add support for S905/S912 #2276

Closed
wants to merge 2 commits into from
Closed

media_build: add support for S905/S912 #2276

wants to merge 2 commits into from

Conversation

spycat88
Copy link
Contributor

@spycat88 spycat88 commented Nov 29, 2017

Self explanatory PR, part of the changes required to bring S905/S912 to LE/master

@kszaq @afl1 @Raybuntu

this is a dependency for the changes to media_build to support
building for S905/S912
@Ray-future
Copy link
Contributor

@adamg-xda Have you seen this: #2270?

@spycat88
Copy link
Contributor Author

I have, there is no specific config in use here, until the PR is merged I obviously can't rebase against it.

@afl1
Copy link
Contributor

afl1 commented Dec 1, 2017

Compiling AMLVIDEO driver as loadable kernel module conflicts with other Amlogic based devices.

@spycat88
Copy link
Contributor Author

spycat88 commented Dec 1, 2017

@afl1 there is an IF statement around the amlvideo code so it is only compiled as a module for S905 and S912

@Ray-future
Copy link
Contributor

This should not be specific to S905 only. It should support all Amlogic 3.14 devices. Not sure what the plans for mediabuild is. Last I checked with @CvH it is going to be moved to addons.

@CvH
Copy link
Member

CvH commented Dec 1, 2017

Buildwise there are no changes, the only change is after the initial build at install().
Instead of hardwiring the kernel to load the module folder kernel/updates/... you can now choose what folder should be loaded (due the addons). The modules itself are build like usual.

@spycat88 spycat88 closed this Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants