projects/Amlogic: add support for S912 devices #2400
Conversation
|
Thank you for submitting this PR! I will add a few suggestions shortly. |
|
Please drop device-specific |
| --with-android-headers=$BUILD/android-headers-25 \ | ||
| --with-default-hybris-ld-library-path=/system/lib \ | ||
| --enable-mali-quirks" | ||
| post_makeinstall_target(){ |
There was a problem hiding this comment.
Please drop post_makeinstall_target() in favour of updated fbdev patch that you can find here:
https://raw.githubusercontent.com/kszaq/LibreELEC.tv/8.2.2.3/packages/devel/libhybris/patches/libhybris-0003-add-fbdev-window-h.patch
There was a problem hiding this comment.
I thought the idea going forward within LE was to reduce the number of patches?
There was a problem hiding this comment.
The patch I linked is already included in your PR but in a different and overblown version. I suggest replacing it with a better version that would also allow you to drop post_makeinstall_target.
There was a problem hiding this comment.
I've just noticed that thanks :) just waiting for compile to finish before updating PR.
|
Thank you for updating the PR. There are still a few kernel options missing, e.g. You don't use MM kernel in your community builds, do you? What I would like to suggest is that I will update projects/Amlogic kernel config to work with S912 devices as soon as we switch to updated kernel in LE master (to this: https://kszaq.libreelec.tv/temp/linux.aarch64.conf), then we can merge this PR without having to update kernel config. |
|
PR is complete, if there is no further reviews. |
libhybris: * bump to latest revision with sync_fence patch merged * simplify Makefile patch (a lot) * get rid of fbdev_window patch kodi: * get rid of fbdev_window * simplify 1920x1080 hack linux: * remove a patch that should go upstream after cleaning up
|
@adamg88 Why have you closed this PR? |
|
Closed for you to take it over, I was told your looking for a way to remove the hacks and set windows resolution properly with libhybris |
This PR adds support for devices with S912 soc.