-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projects/Amlogic: update kernel version and kernel config #2404
Conversation
Added WIP label to discuss kernel options for media drivers. My suggestion is to add IR drivers (especially ir-meson) and not include other modules, e.g. DVB as these are outdated in 3.14 and users should download one of media addons instead. |
Currently we have no dvb addons upstreamed for AML. Even though they are outdated they might be more stable than those experimental media build ones. I'd like to keep the config similar to C2, WH and WP2 so those can be moved under the Amlogic project someday. |
I agree with you @kszaq media drivers should not be included, they should be handled by crazycat, I also agree with @Raybuntu the config should be similar to C2/Wetek to support potentially merging them in the future. On a side note, none of the dvb supporting code has been commited/PR'd yet edit 1: I just noticed you disabled CONFIG_VM_EVENT_COUNTERS I think @MilhouseVH enabled this previously so he may want that retained edit 2: can also confirm config now gives a booting kernel, tested on LePotato edit 3: I couldn't get a U9-H (S912) to boot with this with #2400 |
Thank you @adamg88 for your review. I will re-enable VM_EVENT_COUNTERS, you are correct that they were enabled in all projects. I will check what is missing to support S912. Re media drivers, I think it will be a good idea to include RC drivers, e.g. meson-ir to let users use their remotes without having to install addon drivers. Everything else, i.e. DVB should be installed from media_build(s) as 3.14 drivers are outdated and many of them unusable. |
@adamg88 Have you compiled a device tree for U9 specifically for this kernel? Unfortunately device trees changed again and you can't use these: https://kszaq.libreelec.tv/s912/8.2/device_trees/ |
@kszaq no I used the one from the link above, I will test again later and let you know thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
43dbd3d
to
68708ee
Compare
Thank you @adamg88 for confirming that it works. I have updated kernel config re-enabling VM_EVENT_COUNTERS and rc drivers. Will test is and should be good to go. |
This PR is good to go if there are no objections. @adamg88 I uploaded all device trees for the updated kernel: https://kszaq.libreelec.tv/s905/9.0/device_trees/ |
Imho it would be good to have some basic media/dvb support like we have on C2, WH and WP2. Mediabuild will always be experimental. For instance I'm using Sundtek DVB devices and therefore don't need any mediabuild. |
Ray I think it would be better to leave it till it's enabled in crazycat, community builds can fill the void until then seeing as it will be some time before there is an Official LE release for Aml. |
Sure, I can align media config to WeTek/C2. |
Most of changes are related to Nougat kernel update and aligning config to other projects. Some of the options are required to add S912-on-libhybris: * CONFIG_HMP_VARIABLE_SCALE * CONFIG_NR_CPUS * CONFIG_ARM_BIG_LITTLE_CPUFREQ * CONFIG_FB_OSD_SUPPORT_SYNC_FENCE * CONFIG_FB_OSD2_CURSOR * CONFIG_ASHMEM * CONFIG_SW_SYNC * CONFIG_PSTORE
68708ee
to
80c9546
Compare
Media config copied from Odroid_C2 and redacted by running Builds and runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This PR:
Reasons for kernel options are listed in commit message.
As a bonus, projects/Amlogic now compiles. Runtime tested on a S905X device.