Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix perf build #2505

Merged
merged 5 commits into from Feb 22, 2018
Merged

fix perf build #2505

merged 5 commits into from Feb 22, 2018

Conversation

@HiassofT
Copy link
Member

HiassofT commented Feb 17, 2018

perf crosscompilation should be performed like for linux kernel, i.e. by specifying ARCH and CROSS_COMPILE. The initial version accidentally dropped LDFLAGS, add these back in.

On x86_64 the upstream Makefile adds -llzma to the libunwind libs, patch this out as we don't build lzma in LE.

Also cleanup libunwind package.mk so that headers and static libs are only installed to sysroot

HiassofT added 2 commits Feb 17, 2018
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
properly set ARCH, CROSS_COMPILE, LDFLAGS and JOBS.

This fixes build failure on aarch64 / kernel 4.4 and feature
detection issues due to LTO warnings on 32bit Rockchip builds.

Signed-off-by: Matthias Reichl <hias@horus.com>
@HiassofT

This comment has been minimized.

Copy link
Member Author

HiassofT commented Feb 19, 2018

Clean build revealed that libbfd went AWOL in the original perf PR.

Added the missing commit here and verified with another clean build that C++ demangling works again.

This should be good now

HiassofT added 2 commits Feb 19, 2018
Signed-off-by: Matthias Reichl <hias@horus.com>
Don't pollute sysroot with static libs and headers

Signed-off-by: Matthias Reichl <hias@horus.com>
@HiassofT HiassofT force-pushed the HiassofT:le9-perf-fix branch 3 times, most recently from a780184 to 6b7a5ce Feb 20, 2018
@HiassofT

This comment has been minimized.

Copy link
Member Author

HiassofT commented Feb 20, 2018

The reason for the size change of the perf binary on rebuilds was that gdb polluted the sysroot with it's own version of libbfd, overwriting libbfd headers and includes from binutils.

I've added a gdb commit to stop this nonsense and install gdb only to the target, keeping the sysroot intact

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

MilhouseVH commented Feb 20, 2018

Looks good @HiassofT - perf size (RPi/RPi2/Generic) remains the same after the incremental build. Many thanks for tracking this down!

@MilhouseVH MilhouseVH merged commit 0e3461a into LibreELEC:master Feb 22, 2018
@HiassofT HiassofT deleted the HiassofT:le9-perf-fix branch May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.