fix perf build #2505
Merged
fix perf build #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
properly set ARCH, CROSS_COMPILE, LDFLAGS and JOBS. This fixes build failure on aarch64 / kernel 4.4 and feature detection issues due to LTO warnings on 32bit Rockchip builds. Signed-off-by: Matthias Reichl <hias@horus.com>
HiassofT
force-pushed
the
le9-perf-fix
branch
from
22714f3
to
c01fab4
Compare
|
Clean build revealed that libbfd went AWOL in the original perf PR. Added the missing commit here and verified with another clean build that C++ demangling works again. This should be good now |
Signed-off-by: Matthias Reichl <hias@horus.com>
Don't pollute sysroot with static libs and headers Signed-off-by: Matthias Reichl <hias@horus.com>
HiassofT
force-pushed
the
le9-perf-fix
branch
3 times, most recently
from
a780184
to
6b7a5ce
Compare
|
The reason for the size change of the perf binary on rebuilds was that gdb polluted the sysroot with it's own version of libbfd, overwriting libbfd headers and includes from binutils. I've added a gdb commit to stop this nonsense and install gdb only to the target, keeping the sysroot intact |
|
Looks good @HiassofT - perf size (RPi/RPi2/Generic) remains the same after the incremental build. Many thanks for tracking this down! |
MilhouseVH
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf crosscompilation should be performed like for linux kernel, i.e. by specifying ARCH and CROSS_COMPILE. The initial version accidentally dropped LDFLAGS, add these back in.
On x86_64 the upstream Makefile adds -llzma to the libunwind libs, patch this out as we don't build lzma in LE.
Also cleanup libunwind package.mk so that headers and static libs are only installed to sysroot