Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_addon: two improvments #2868

Merged
merged 2 commits into from
Aug 6, 2018
Merged

create_addon: two improvments #2868

merged 2 commits into from
Aug 6, 2018

Conversation

InuSasha
Copy link
Member

@InuSasha InuSasha commented Aug 4, 2018

  • allow to build addons with sourced PKG_IS_ADDON variable
  • change state of "not supported" messages from ERROR to SKIP

@InuSasha
create_addon: two improvments
0c82bda 
* allow to build addons with sourced `PKG_IS_ADDON` variable
* change state of "not supported" messages from `ERROR` to `SKIP`
@InuSasha
Copy link
Member Author

InuSasha commented Aug 6, 2018 •
edited
Loading

@chewitt: I removed the ADDON SUCCESS message. But I had to add an addon completed, because relevant tasks come after compressing addon.

chewitt
chewitt approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@chewitt chewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks cleaner :)

@chewitt chewitt merged commit 31c86ba into LibreELEC:master Aug 6, 2018
@InuSasha InuSasha deleted the fix/create_addon_included branch August 7, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewitt chewitt chewitt approved these changes

Assignees
No one assigned
Labels
ADDONS BUGFIX BUILDSYSTEM LE 9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InuSasha @chewitt @CvH