Various: Scattered trivial cleanups #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
MilhouseVH
reviewed
Oct 5, 2018
scripts/checkdeps
Outdated
| get_yes_no && sudo apt-get install "${need_pkg[@]}" | ||
| ;; | ||
| fedora|centos|rhel) | ||
| if command -v dnf >/dev/null; then YUM=dnf; else YUM=yum; fi |
There was a problem hiding this comment.
command -v dnf >/dev/null && YUM=dnf || YUM=yum
?
There was a problem hiding this comment.
Looks good to me.
|
Other than the small nit this looks good to me, thanks. |
|
config/functions: pair of what I believe to be unused functions anywhere. eglibc was rolled into glibc proper a few years ago. tolower() has been around for years and just appears unused. It could be improved if it stays. |
Replace "which" with "command -v", which is part of POSIX. Make offering to install packages contingent on having the sudo command. Not every distro uses sudo. It is optional in Gentoo, for example. Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
eglibc ceased active development years ago and is no longer in tree, so no need to check for it. tolower() has been around since 2010 and is unused anywhere. Wish it well! Should it return, tr '[:upper:]' '[:lower:]' is likely better. Signed-off-by: Ian Leonard <antonlacon@gmail.com>
antonlacon
force-pushed
the
housekeeping
branch
from
8d345c5
to
520391b
Compare
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
|
mkpkg_lockdev: drop as lockdev was dropped from tree early August. |
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
|
.gitignore: adding lost+found should it be on a dedicated filesystem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some cleanup commits that have been floating around my branches. All of them are fairly trivial, so I grouped them up.
rpi: housekeeping edits comments to reflect the options available to the RPi.
projects: ratpoison removes references to the ratpoison wm from the project comments. I believe ratpoison was dropped a couple years ago from the tree.
config/options: replaces "which" with "command -v". Command -v is POSIX and has the same result as which. nproc is part of coreutils, and returns the number of processing units available, which is what the grep expression was up to.
scripts/checkdeps: which to command -v, and be more graceful when the 'sudo' command isn't present. I don't have sudo on my machines.