u-boot: only append suffix when creating multiple u-boot variants #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwiboo
approved these changes
Oct 6, 2018
There was a problem hiding this comment.
Looks good, but may not be useful for Rockchip without more changes as UBOOT_SYSTEM must match SoC name for bootloader install script to select correct blobs.
Best approach for fixing the strange TinkerBoard and MiQi image names will be to merge the TinkerBoard/MiQi devices into a common RK3288 soc device.
https://github.com/LibreELEC/LibreELEC.tv/blob/master/projects/Rockchip/bootloader/install#L5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies SBC image filenames by only appending the board-type suffix when the image file is one of multiple u-boot variants, e.g.
LibreELEC-RK3399.arm-8.90.006-rockpro64.img.gzwill remain the same. If the device has its own u-boot variant and entry inscripts/uboot-helperthe name is shortened, e.g.LibreELEC-TinkerBoard.arm-8.90.006-rk3288.img.gzbecomes shortened toLibreELEC-TinkerBoard.arm-8.90.006.img.gz. To work the scripts/uboot-helper entries just need to match the buildsystem$DEVICEname.