Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: enable switch debug-tty to provide a debug console #3326

Merged
merged 1 commit into from
May 8, 2019

Conversation

lrusak
Copy link
Member

@lrusak lrusak commented Feb 22, 2019

This allows us to use the default debug-shell.service provided by systemd and cut down on custom made services. This will also always provide a debug shell as there is no reason we shouldn't have access to one.

This defaults to /dev/tty3 (like was default before) but is overridden by project specific tty's such as /dev/ttyS2

see, https://freedesktop.org/wiki/Software/systemd/Debugging/
and, https://github.com/systemd/systemd/blob/master/meson_options.txt#L49

This allows us to use the default debug-shell.service provided
by systemd and cut down on custom made services. This will also
always provide a debug shell as there is no reason we shouldn't
have access to one.
@lrusak
Copy link
Member Author

lrusak commented May 8, 2019

Can someone review?

@MilhouseVH MilhouseVH merged commit d6593e0 into LibreELEC:master May 8, 2019
@MilhouseVH
Copy link
Contributor

This has broken the console prompt:

  1. the prompt is no longer the hostname
  2. the cursor is no longer visible with this PR (although it can be enabled with reset)

The following screenshots are from RPi2 but it's the same situation with Generic (ALT-F3).

Before (#0507):
s1

After (#0508):
s1

Both issues are fairly cosmetic, but is it possible to reproduce the old behaviour, or is this new behaviour intentional?

chewitt added a commit that referenced this pull request Jul 3, 2019
HiassofT pushed a commit to HiassofT/LibreELEC.tv that referenced this pull request Sep 19, 2019
/etc/98-busybox.conf configures the prompt and TERM.

PR LibreELEC#3326 stopped sourcing /etc/profile, which meant the
prompt no longer includes the HOSTNAME.

Additionally, LibreELEC#3326 removed code which unhides the cursor.
escalade added a commit to escalade/RetroELEC that referenced this pull request Sep 19, 2019
/etc/98-busybox.conf configures the prompt and TERM.

PR LibreELEC#3326 stopped sourcing /etc/profile, which meant the
prompt no longer includes the HOSTNAME.

Additionally, LibreELEC#3326 removed code which unhides the cursor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants