brcmfmac_sdio-firmware-rpi: fix delay on non-wifi enabled devices #3356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3354 introduces a startup delay of over 90 seconds on devices without built-in WiFi/Bluetooth (ie. RPi0, RPi1, RPi2) as services such as Kodi will wait for
network.target
to be reached, which is itself blocked while waiting forbrcmfmac_sdio-firmware-rpi
service which cannot start until devicedev-serial1
becomes available, or times out.The upstream service includes a condition check which doesn't really work as the service still blocks while waiting for the
dev-serial1
job to start, which never happens on RPi0/1/2 so the service eventually times out, but I'll include it anyway as it shouldn't do any harm. Likely not an issue on upstream due to different dependencies. However my understanding is that the condition should mean the service silently fails rather, but that doesn't seem to be happening, it still blocks on the device.Scheduling this service after
network.target
avoids blockingnetwork.target
- eventually this service will fail after 90 seconds once thedev-serial1
job times out, or Bluetooth will be configured concurrently with other network-dependent services (eg. Kodi).