Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brcmfmac_sdio-firmware-rpi: fix delay on non-wifi enabled devices #3356

Merged
merged 1 commit into from
Mar 19, 2019
Merged

brcmfmac_sdio-firmware-rpi: fix delay on non-wifi enabled devices #3356

merged 1 commit into from
Mar 19, 2019

Conversation

MilhouseVH
Copy link
Contributor

#3354 introduces a startup delay of over 90 seconds on devices without built-in WiFi/Bluetooth (ie. RPi0, RPi1, RPi2) as services such as Kodi will wait for network.target to be reached, which is itself blocked while waiting for brcmfmac_sdio-firmware-rpi service which cannot start until device dev-serial1 becomes available, or times out.

The upstream service includes a condition check which doesn't really work as the service still blocks while waiting for the dev-serial1 job to start, which never happens on RPi0/1/2 so the service eventually times out, but I'll include it anyway as it shouldn't do any harm. Likely not an issue on upstream due to different dependencies. However my understanding is that the condition should mean the service silently fails rather, but that doesn't seem to be happening, it still blocks on the device.

Scheduling this service after network.target avoids blocking network.target - eventually this service will fail after 90 seconds once the dev-serial1 job times out, or Bluetooth will be configured concurrently with other network-dependent services (eg. Kodi).

Mar 07 04:56:20 rpi512 systemd[1]: dev-serial1.device: Job dev-serial1.device/start timed out.
Mar 07 04:56:20 rpi512 systemd[1]: Timed out waiting for device dev-serial1.device.
Mar 07 04:56:20 rpi512 systemd[1]: Dependency failed for Broadcom sdio firmware update for BCM43430A1.
Mar 07 04:56:20 rpi512 systemd[1]: brcmfmac_sdio-firmware.service: Job brcmfmac_sdio-firmware.service/start failed with result 'dependency'.
Mar 07 04:56:20 rpi512 systemd[1]: dev-serial1.device: Job dev-serial1.device/start failed with result 'timeout'.
Mar 07 04:56:20 rpi512 systemd[1]: Reached target Network.
Mar 07 04:56:20 rpi512 systemd[1]: Reached target Network is Online.

@chewitt chewitt merged commit 1005b7c into LibreELEC:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants