Python3: fix year 2038 regression on 32-bit #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we might as well merge this - I have a feeling it's unlikely to be fixed upstream any time soon. If/when it is, we can drop this small patch. |
CvH
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://bugs.python.org/issue5537#msg361962
Forum: https://forum.libreelec.tv/thread/21369-exception-when-trying-to-save-lwpcookiejar-in-addon-on-milhouse-nightly/
Creating as a draft in case there's further discussion/changes in the issue before being marked as "fixed" in Python3.
This is also broken in Python2, and since the fix appears trivial it could be pushed as a backport.