Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: fix for saving sking settings on shutdown #521

Merged
merged 1 commit into from Jul 9, 2016
Merged

kodi: fix for saving sking settings on shutdown #521

merged 1 commit into from Jul 9, 2016

Conversation

stefansaraev
Copy link
Contributor

backport xbmc/xbmc#9696 to Jarvis

this should fix a known issue after kodi moved skin settings out of guisettings.xml (fixed in krypton) but I am unable to build / runtime test it, so please do a quick test before merging

ref: https://forum.libreelec.tv/thread-53.html

@lrusak
Copy link
Member

lrusak commented Jul 7, 2016

Thanks @stefansaraev ❤️

@kszaq
Copy link
Contributor

kszaq commented Jul 7, 2016

For the record, I've been using this fix from Koying in my community builds: koying/SPMC@91a7962 and there have been no complaints about skin settings not saving since including it.

@stefansaraev
Copy link
Contributor Author

stefansaraev commented Jul 7, 2016

@kszaq yep, yours will work too. it will force saving every time random setting is changed, which may be slow, and could potentionaly be racy (may corrupt your settings at some point, very unikely to happen but still..)

mine is a bit simpler, it only guarantees that saving skin settings is not blocked by other misbehaving addon, or a crash on kodi exit. if kodi crashes meanwhile, settings wont be saved. it is same behaviour as for guisettings.xml but that's another story

@MilhouseVH
Copy link
Contributor

I've successfully built this for RPi/RPi2/Generic. Have tested RPi2 and it works as expected.

@lrusak lrusak merged commit 94cb7aa into LibreELEC:libreelec-7.0 Jul 9, 2016
@stefansaraev stefansaraev deleted the 70-skinfix branch July 9, 2016 17:41
droidbox pushed a commit to droidbox/LibreELEC.tv that referenced this pull request Jan 3, 2017
kodi: fix for saving sking settings on shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants