Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeTek: Set the resolution more precisely at boot #541

Merged
merged 1 commit into from Jul 17, 2016

Conversation

drieschel
Copy link
Contributor

@drieschel drieschel commented Jul 14, 2016

This commit checks the resolution capabilities of the hdmi device and sets the framebuffer resolution depending on the max resolution of the device and the selected resolution by hdmimode boot parameter.

Tested with WeTek Core and Beelink MXIII (S802) connected to a 4K Hisense tv.

Edit: Nothing. :D

@drieschel drieschel changed the title Set the resolution more precisely at boot WeTek: Set the resolution more precisely at boot Jul 14, 2016
@lrusak
Copy link
Member

lrusak commented Jul 15, 2016

Looks pretty good. Was this work actually done by @codesnake ?

@drieschel
Copy link
Contributor Author

I think the old version was Codesnake's work. The changes are from me.

@codesnake
Copy link
Collaborator

No, this is not my work, but looks good - 👍

@chewitt chewitt merged commit 0f8bbb6 into LibreELEC:master Jul 17, 2016
@@ -1,7 +1,7 @@
#!/bin/sh
################################################################################
# This file is part of OpenELEC - http://www.openelec.tv
# Copyright (C) 2009-2016 Stephan Raue (stephan@openelec.tv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the copyright looks fishy for me.

Gerald

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also adding the new copyright line which directing to someone who has not done this looks fishy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the init_script from the WeTek_Play project adapted it and copied it also to the WeTek_Core project. So what do you propose to do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the vast majority of the content of the two platform_init files appears to be new and original work I'd replace the OpenELEC licence with the standard LibreELEC licence. If you don't want to put yourself as copyright then use Team LibreELEC - see distro-tool as an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a problem. But I have to do a new pull request for that.

@drieschel drieschel mentioned this pull request Jul 18, 2016
@drieschel drieschel deleted the boot-resolution branch July 23, 2016 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants