Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventlircd: Add support for Amazon Fire TV Stick Bluetooth remote #556

Merged
merged 1 commit into from Jul 22, 2016

Conversation

@lrusak
Copy link
Member

commented Jul 20, 2016

@DBMandrake, I hope it is ok that I made you the commit author as you are the one that made the commit for OSMC, I wanted to give you credit for it.

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2016

please merge if no objections

@MilhouseVH MilhouseVH merged commit b74e416 into LibreELEC:master Jul 22, 2016
KEY_LEFT = KEY_LEFT
KEY_RIGHT = KEY_RIGHT
KEY_DOWN = KEY_DOWN
KEY_MENU = KEY_TITLE

This comment has been minimized.

Copy link
@HitcherUK

HitcherUK Jul 29, 2016

@lrusak I think this is causing the menu button on the Fire TV remote to only work as the next subtitle button <subtitle>NextSubtitle</subtitle> instead of something more useful like the context menu <menu>ContextMenu</menu>

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2016

changing this to KEY_EPG might help as it was done here, dd0da2c

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2016

This seems to cause problems for FireTV remote users, who are having to revert this change manually:

http://forum.kodi.tv/showthread.php?pid=2380867#pid2380867
http://forum.kodi.tv/showthread.php?tid=269815&pid=2403303#pid2403303

What benefit does this PR provide if FireTV remote users are having problems? Should we revert this?

@HitcherUK

This comment has been minimized.

Copy link

commented Aug 28, 2016

I couldn't see the reasoning behind it when my Fire TV remote worked just fine.

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2016

The reason is that it didn't work OOTB as I understand and you needed a custom keymap.xml file for it to work.

If you guys really don't want to try and do this the right way then just revert it.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2016

Of course we/I want to do it the right way... I just hadn't realised there was a problem that needed fixing, but since this change people have complained.

@HitcherUK can you confirm if this FireTV remote "works" using default LE settings and keyboard mappings? Maybe we need to work on your custom keymap.xml in the forum, I've no idea why that has stopped working after this change... not sure if you posted your keymap.xml or a debug log to the forum.

@HitcherUK

This comment has been minimized.

Copy link

commented Aug 29, 2016

Long press broke and I couldn't get the menu button to do anything other than toggle subtitles.

When I find some time I'll run a clean LE and report back, then we can hopefully work from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.