eventlircd: Add support for Amazon Fire TV Stick Bluetooth remote #556
Conversation
|
please merge if no objections |
| KEY_LEFT = KEY_LEFT | ||
| KEY_RIGHT = KEY_RIGHT | ||
| KEY_DOWN = KEY_DOWN | ||
| KEY_MENU = KEY_TITLE |
There was a problem hiding this comment.
@lrusak I think this is causing the menu button on the Fire TV remote to only work as the next subtitle button <subtitle>NextSubtitle</subtitle> instead of something more useful like the context menu <menu>ContextMenu</menu>
|
changing this to KEY_EPG might help as it was done here, dd0da2c |
|
This seems to cause problems for FireTV remote users, who are having to revert this change manually: http://forum.kodi.tv/showthread.php?pid=2380867#pid2380867 What benefit does this PR provide if FireTV remote users are having problems? Should we revert this? |
|
I couldn't see the reasoning behind it when my Fire TV remote worked just fine. |
|
The reason is that it didn't work OOTB as I understand and you needed a custom keymap.xml file for it to work. If you guys really don't want to try and do this the right way then just revert it. |
|
Of course we/I want to do it the right way... I just hadn't realised there was a problem that needed fixing, but since this change people have complained. @HitcherUK can you confirm if this FireTV remote "works" using default LE settings and keyboard mappings? Maybe we need to work on your custom keymap.xml in the forum, I've no idea why that has stopped working after this change... not sure if you posted your keymap.xml or a debug log to the forum. |
|
Long press broke and I couldn't get the menu button to do anything other than toggle subtitles. When I find some time I'll run a clean LE and report back, then we can hopefully work from there. |
@DBMandrake, I hope it is ok that I made you the commit author as you are the one that made the commit for OSMC, I wanted to give you credit for it.