samba: fix browsing and clean up smb.conf #849
Conversation
| @@ -27,18 +27,12 @@ | |||
| security = share | |||
| guest account = root | |||
| socket options = TCP_NODELAY IPTOS_LOWDELAY | |||
| smb ports = 445 | |||
| max protocol = SMB2 | |||
There was a problem hiding this comment.
I would leave max protocol = SMB2 otherwise samba will use NT1
From samba 3.6.0 release notes:
SMB2 support in 3.6.0 is fully functional (with one omission)
...
As this is the first release containing what we consider
to be a fully featured SMB2 protocol, we are not enabling
this by default, but encourage users to enable SMB2 and
test it.
There was a problem hiding this comment.
You're right, I was looking at a more recent manual page where SMB3 was the default. Corrected.
|
Please don't change the licence header. |
|
Changed it back, but why wouldn't you want to change it? It's not like Samba configuration directives is a product of OpenELEC. |
| mangled names = no | ||
| syslog only = yes | ||
| syslog = 2 | ||
| name resolve order = lmhosts wins bcast host | ||
| preferred master = auto |
There was a problem hiding this comment.
I'd leave the three master settings and os level in the config even if they're at default values. If people need to create a custom config it's one of the more frequent things to edit.
There was a problem hiding this comment.
I'd say you really shouldn't be changing the preferred master and os level unless you know what you're doing, and if you do then you probably don't need them listed. Anyways, I'll put them back if you like.
There was a problem hiding this comment.
Or include them, but comment them out?
| # local master = yes | ||
| # preferred master = auto | ||
| # domain master = auto | ||
| # os level = 20 |
There was a problem hiding this comment.
If we go with the commented solution I suppose an extra comment "# The following are the default values, but included for informational purposes" (or words to that effect) might be useful so that someone in 6 months time doesn't submit a PR removing them because they're the default values and therefore unnecessary etc. etc.
| # local master = yes | ||
| # preferred master = auto | ||
| # domain master = auto | ||
| # os level = 20 | ||
|
|
|
It's no issue to change the license header as long as we carry forward the original copyright owner information and dates, but at some point we can do a bulk fixup on that. It's not a big deal for now. Thanks @escalade :) |
|
Now getting reports of broken |
|
Looks like the report you mention is regarding Kodi SMB to a NAS, so nothing to do with the Samba service. |
|
Yes, it's rather confusing. There were eventually two problem reports, one now has a working system after build #1023 (clean build, no other relevant changes). The other person reporting a problem now seems to have a name resolution issue. Neither is running the local Samba server, but were adamant that restoring the original smb.conf restored working smb://, a solution that doesn't make any sense. I think it's most likely a random and unrelated local network failure that coincided with this smb.conf change, but can't be entirely certain. |
As pointed out in this thread, browsing in LibreELEC is currently (and seems to have been for some time) broken. The default value for "smb ports" is "445 139", so setting only 445 effectively disables NetBIOS. As Samba by default (as it should) participates in local master browser elections, browsing will stop working if it wins.
Other changes:
os level <- 20 is the default
name resolve order <- we do not ship /etc/samba/lmhosts and we do not use wins by default so it should be last. hosts should always take preference
preferred master, domain master, local master <- these are all at default values so should be omitted