Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: fix browsing and clean up smb.conf #849

Merged
merged 1 commit into from
Oct 21, 2016
Merged

samba: fix browsing and clean up smb.conf #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/network/samba/config/smb.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,13 @@
security = share
guest account = root
socket options = TCP_NODELAY IPTOS_LOWDELAY
smb ports = 445
max protocol = SMB2
min receivefile size = 16384
deadtime = 30
os level = 20
mangled names = no
syslog only = yes
syslog = 2
name resolve order = lmhosts wins bcast host
preferred master = auto
domain master = auto
local master = yes
name resolve order = host bcast wins
printcap name = /dev/null
load printers = no
browseable = yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave the three master settings and os level in the config even if they're at default values. If people need to create a custom config it's one of the more frequent things to edit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say you really shouldn't be changing the preferred master and os level unless you know what you're doing, and if you do then you probably don't need them listed. Anyways, I'll put them back if you like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or include them, but comment them out?

Expand All @@ -49,6 +44,11 @@
passdb backend = smbpasswd
smb encrypt = disabled
use sendfile = yes
# The following are default values for the master selection process
# local master = yes
# preferred master = auto
# domain master = auto
# os level = 20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


# Using the following configurations as a template allows you to add
Expand Down