Kodi 17 (redo)

[lrusak]

github was having issues so I am opening a new PR

please see #12 for previous discussion.

[MilhouseVH]

Thanks for this.

When you get a moment, would you mind adding the p8-platform bump for screensaver.shadertoy:

https://gist.github.com/MilhouseVH/035a229631eaa316c1e021895eac5ee6

[lrusak]

done

[AchimTuran]

@lrusak
Awesome visualization.pictureit: initial add-on I will ping you when it is ready.

[lrusak]

added
inputstream.smoothstream
visualization.pictureit

[stefansaraev]

pictureit will fail if no opengl is found. you should build it only for generic.

[lrusak]

@stefansaraev yes thanks 👍 updated

[stefansaraev]

@AchimTuran any plans making pictureit gles compatible ?

[stefansaraev]

you should use appliance.xml. not patching settings.xml

[lrusak]

I'm wondering if I should even include this as I'm not sure it's relevant for all platforms

[stefansaraev]

<settings>
  ...
  <section id="system">
    ... 
    <category id="videoscreen">
      ... 
      <group id="3">
        <setting id="videoscreen.limitedrange">
          <default>true</default>
        </setting>
      </group>
    </category>
   ...
  </section>
  ...
</settings>

EDIT: then remove your guisettings.xml. killall -9 kodi.bin and check if <limitedrange default="true">true</limitedrange> is saved to guisettings next run.

[stefansaraev]

I'm wondering if I should even include this as I'm not sure it's relevant for all platforms

you have project specific appliance.xmls. do for generic.

EDIT: huh. there is not. :)

[stefansaraev]

it depends on at HAS_GL | HAS_DX. does nothing on other platforms. so it is safe for pi/imx/wetek

[fritsch]

This setting only makes sense if:

• xrandr is running Full Mode (and TV ignores it and thinks it is limited ;-))
• xrandr is set to the Video Range 16:235 which is not to be confused with Limited 16:235 mode

For VDPAU I have no good idea as of yet on howto do it properly. As it needs a special xorg.conf to my knowledge to force full rgb or limited rgb.

[stefansaraev]

so. it does not hurt amd/nvidia users ?

[fritsch]

This setting actively hurts (!) if the above two conditions are not met.

Think of the following: GPU outputs 16:235 but assumes input is 0:255 - now this setting is ticked it will scale (!) again 16.235 to e.g. 24:220 which means: no blacks no whites anymore.

I don't see a solution that would fit all of them.

[AchimTuran]

@stefansaraev

@AchimTuran any plans making pictureit gles compatible ?

I can't give a detailed answer to this question, because I'm not the maintainer of this add-on. I only help with the spectrum post processing part. But according to @tadly 's post in the development thread of PictureIt. I guess he will ;-)

@tadly

Currently I'm focusing on finishing v1.0 of the vis and after that I'll try to support as many platforms as possible

[tadly]

Tadly goes and deletes that line from the thread :D

@stefansaraev
na, just kidding.
But the I'll try to is meant like it.
My understanding of ogl still goes near 0 and all I created so far is heavily based on examples and tinkering.

So if I'll be able to port it to gles and directx has to be seen.
(First I gotta learn shaders though and well... get v1 released)

But the source is open for everyone so.. wink :)

[stefansaraev]

oh, it was @tadly not you, @AchimTuran :)

[lrusak]

updated, this is probably going to be as good as it get's we can adjust things after it gets merged.

[the-dreamer]

inputstream.mpd is not build when trying to build libssd_wv.so:
make: *** No rule to make target 'install'. Stop.
i can fix that when make_post_target() is replaced by this https://github.com/fritsch/OpenELEC.tv/blob/krypton-egl/packages/mediacenter/kodi-binary-addons/inputstream.mpd/package.mk#L38

unfortunately libssd_wv.so needs to be copied at runtime to storage/.kodi/cdm.

my above mentions still applies.

[MilhouseVH]

I think inputstream.mpd just needs a bump (and maybe a small change - it's been a moving target over the last couple of weeks)... Frankly the sooner we merge this the sooner we can stop fretting over these breaks and just push individual PRs as/when required.

[MilhouseVH]

And many thanks @lrusak for maintaining this PR over the few months! :)