-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kodi 17 (redo) #98
Kodi 17 (redo) #98
Conversation
Thanks for this. When you get a moment, would you mind adding the p8-platform bump for screensaver.shadertoy: https://gist.github.com/MilhouseVH/035a229631eaa316c1e021895eac5ee6 |
done |
f3847cc
to
32d63e8
Compare
@lrusak |
b71ab15
to
7dadf13
Compare
added |
pictureit will fail if no opengl is found. you should build it only for generic. |
78b85d5
to
75e8a91
Compare
@stefansaraev yes thanks 👍 updated |
@AchimTuran any plans making pictureit gles compatible ? |
</updates> | ||
-- | ||
1.9.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should use appliance.xml. not patching settings.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if I should even include this as I'm not sure it's relevant for all platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<settings>
...
<section id="system">
...
<category id="videoscreen">
...
<group id="3">
<setting id="videoscreen.limitedrange">
<default>true</default>
</setting>
</group>
</category>
...
</section>
...
</settings>
EDIT: then remove your guisettings.xml. killall -9 kodi.bin and check if <limitedrange default="true">true</limitedrange>
is saved to guisettings next run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if I should even include this as I'm not sure it's relevant for all platforms
you have project specific appliance.xmls. do for generic.
EDIT: huh. there is not. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it depends on at HAS_GL | HAS_DX. does nothing on other platforms. so it is safe for pi/imx/wetek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setting only makes sense if:
- xrandr is running Full Mode (and TV ignores it and thinks it is limited ;-))
- xrandr is set to the Video Range 16:235 which is not to be confused with Limited 16:235 mode
For VDPAU I have no good idea as of yet on howto do it properly. As it needs a special xorg.conf to my knowledge to force full rgb or limited rgb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so. it does not hurt amd/nvidia users ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setting actively hurts (!) if the above two conditions are not met.
Think of the following: GPU outputs 16:235 but assumes input is 0:255 - now this setting is ticked it will scale (!) again 16.235 to e.g. 24:220 which means: no blacks no whites anymore.
I don't see a solution that would fit all of them.
747f751
to
b81c2ad
Compare
I can't give a detailed answer to this question, because I'm not the maintainer of this add-on. I only help with the spectrum post processing part. But according to @tadly 's post in the development thread of PictureIt. I guess he will ;-)
|
Tadly goes and deletes that line from the thread :D @stefansaraev So if I'll be able to port it to gles and directx has to be seen. But the source is open for everyone so.. wink :) |
oh, it was @tadly not you, @AchimTuran :) |
updated, this is probably going to be as good as it get's we can adjust things after it gets merged. |
inputstream.mpd is not build when trying to build libssd_wv.so: unfortunately libssd_wv.so needs to be copied at runtime to storage/.kodi/cdm. my above mentions still applies. |
I think inputstream.mpd just needs a bump (and maybe a small change - it's been a moving target over the last couple of weeks)... Frankly the sooner we merge this the sooner we can stop fretting over these breaks and just push individual PRs as/when required. |
And many thanks @lrusak for maintaining this PR over the few months! :) |
github was having issues so I am opening a new PR
please see #12 for previous discussion.