Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodi 17 (redo) #98

Merged
merged 22 commits into from Apr 18, 2016

Conversation

Projects
None yet
@lrusak
Copy link
Member

commented Apr 4, 2016

github was having issues so I am opening a new PR

please see #12 for previous discussion.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2016

Thanks for this.

When you get a moment, would you mind adding the p8-platform bump for screensaver.shadertoy:

https://gist.github.com/MilhouseVH/035a229631eaa316c1e021895eac5ee6

@lrusak lrusak force-pushed the lrusak:kodi-17 branch from dcb90b0 to eeb5a89 Apr 5, 2016

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2016

done

@lrusak lrusak force-pushed the lrusak:kodi-17 branch 3 times, most recently from f3847cc to 32d63e8 Apr 11, 2016

@AchimTuran

This comment has been minimized.

Copy link

commented Apr 11, 2016

@lrusak
Awesome visualization.pictureit: initial add-on I will ping you when it is ready.

@lrusak lrusak force-pushed the lrusak:kodi-17 branch 3 times, most recently from b71ab15 to 7dadf13 Apr 11, 2016

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2016

added
inputstream.smoothstream
visualization.pictureit

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2016

pictureit will fail if no opengl is found. you should build it only for generic.

@lrusak lrusak force-pushed the lrusak:kodi-17 branch 2 times, most recently from 78b85d5 to 75e8a91 Apr 11, 2016

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2016

@stefansaraev yes thanks 👍 updated

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2016

@AchimTuran any plans making pictureit gles compatible ?

</updates>
--
1.9.1

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Apr 11, 2016

Contributor

you should use appliance.xml. not patching settings.xml

This comment has been minimized.

Copy link
@lrusak

lrusak Apr 11, 2016

Author Member

I'm wondering if I should even include this as I'm not sure it's relevant for all platforms

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Apr 11, 2016

Contributor
<settings>
  ...
  <section id="system">
    ... 
    <category id="videoscreen">
      ... 
      <group id="3">
        <setting id="videoscreen.limitedrange">
          <default>true</default>
        </setting>
      </group>
    </category>
   ...
  </section>
  ...
</settings>

EDIT: then remove your guisettings.xml. killall -9 kodi.bin and check if <limitedrange default="true">true</limitedrange> is saved to guisettings next run.

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Apr 11, 2016

Contributor

I'm wondering if I should even include this as I'm not sure it's relevant for all platforms

you have project specific appliance.xmls. do for generic.

EDIT: huh. there is not. :)

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Apr 11, 2016

Contributor

it depends on at HAS_GL | HAS_DX. does nothing on other platforms. so it is safe for pi/imx/wetek

This comment has been minimized.

Copy link
@fritsch

fritsch Apr 11, 2016

Contributor

This setting only makes sense if:

  • xrandr is running Full Mode (and TV ignores it and thinks it is limited ;-))
  • xrandr is set to the Video Range 16:235 which is not to be confused with Limited 16:235 mode

For VDPAU I have no good idea as of yet on howto do it properly. As it needs a special xorg.conf to my knowledge to force full rgb or limited rgb.

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Apr 11, 2016

Contributor

so. it does not hurt amd/nvidia users ?

This comment has been minimized.

Copy link
@fritsch

fritsch Apr 11, 2016

Contributor

This setting actively hurts (!) if the above two conditions are not met.

Think of the following: GPU outputs 16:235 but assumes input is 0:255 - now this setting is ticked it will scale (!) again 16.235 to e.g. 24:220 which means: no blacks no whites anymore.

I don't see a solution that would fit all of them.

@@ -298,15 +301,11 @@ pre_build_target() {
# adding fake Makefile for stripped skin
mkdir -p $PKG_BUILD/addons/skin.confluence/media

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Apr 11, 2016

Contributor

this is no more.

@lrusak lrusak force-pushed the lrusak:kodi-17 branch 2 times, most recently from 747f751 to b81c2ad Apr 11, 2016

@AchimTuran

This comment has been minimized.

Copy link

commented Apr 13, 2016

@stefansaraev

@AchimTuran any plans making pictureit gles compatible ?

I can't give a detailed answer to this question, because I'm not the maintainer of this add-on. I only help with the spectrum post processing part. But according to @tadly 's post in the development thread of PictureIt. I guess he will ;-)

@tadly

Currently I'm focusing on finishing v1.0 of the vis and after that I'll try to support as many platforms as possible

@tadly

This comment has been minimized.

Copy link

commented Apr 13, 2016

Tadly goes and deletes that line from the thread :D

@stefansaraev
na, just kidding.
But the I'll try to is meant like it.
My understanding of ogl still goes near 0 and all I created so far is heavily based on examples and tinkering.

So if I'll be able to port it to gles and directx has to be seen.
(First I gotta learn shaders though and well... get v1 released)

But the source is open for everyone so.. wink :)

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2016

oh, it was @tadly not you, @AchimTuran :)

@lrusak lrusak force-pushed the lrusak:kodi-17 branch from b81c2ad to 73144b1 Apr 14, 2016

@lrusak lrusak force-pushed the lrusak:kodi-17 branch from 0b6a058 to 6e1c051 Apr 18, 2016

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2016

updated, this is probably going to be as good as it get's we can adjust things after it gets merged.

@the-dreamer

This comment has been minimized.

Copy link

commented Apr 18, 2016

inputstream.mpd is not build when trying to build libssd_wv.so:
make: *** No rule to make target 'install'. Stop.
i can fix that when make_post_target() is replaced by this https://github.com/fritsch/OpenELEC.tv/blob/krypton-egl/packages/mediacenter/kodi-binary-addons/inputstream.mpd/package.mk#L38

unfortunately libssd_wv.so needs to be copied at runtime to storage/.kodi/cdm.

my above mentions still applies.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2016

I think inputstream.mpd just needs a bump (and maybe a small change - it's been a moving target over the last couple of weeks)... Frankly the sooner we merge this the sooner we can stop fretting over these breaks and just push individual PRs as/when required.

@MilhouseVH MilhouseVH merged commit 1090f0d into LibreELEC:master Apr 18, 2016

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2016

And many thanks @lrusak for maintaining this PR over the few months! :)

@bumpaneer

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

replied Apr 19, 2016

Mainly because it's a quick fix, and the settings addon needs a major overhaul for Kodi 17. Not to mention that until recently the Settings addon only supported Kodi 16, so merging this change into the Settings addon wasn't even feasible until Kodi 17 landed in LE master.

This comment has been minimized.

Copy link

replied Apr 19, 2016

Gotcha, thanks for taking the time to explain. Just wanted to make sure I understood what was going on.

Edit: Should have mentioned the reason for my question in the first place relates back to a proposed change to the skin file name: http://forum.libreelec.tv/thread-105.html

This comment has been minimized.

Copy link
Contributor

replied Apr 19, 2016

We'll adapt the patch to whatever changes occur upstream (ideally, we'll drop it). Now that LE master is open for Kodi 17 we can probably start merging Kodi 17 changes to Settings master. If necessary we'll branch the Settings addon for Kodi 16.

This comment has been minimized.

Copy link

replied Apr 22, 2016

I got this error during Libreelec build:

  UNPACK   LibreELEC-settings
      APPLY PATCH (common)   /media/Other/Git/LibreELEC.tv/packages/mediacenter/LibreELEC-settings/patches/LibreELEC-settings-0001-fix-for-kodi-17.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/skins/Default/720p/mainWindow.xml b/skins/Default/720p/mainWindow.xml
|index 19c7676..c63f688 100644
|--- a/skins/Default/720p/mainWindow.xml
|+++ b/skins/Default/720p/mainWindow.xml
--------------------------
File to patch: 
Skip this patch? [y] y
Skipping patch.
5 out of 5 hunks ignored
Makefile:12: ошибка выполнения рецепта для цели «image»
make: *** [image] Ошибка 1

How to fix it?

This comment has been minimized.

Copy link
Contributor

replied Apr 22, 2016

@rinaldus: revert #214 for now.

@bkuhls

This comment has been minimized.

Copy link

commented on packages/mediacenter/kodi/package.mk in 2823d19 Jun 19, 2016

These two sed lines can be removed after PR xbmc/xbmc#9814

This comment has been minimized.

Copy link
Contributor

replied Jun 24, 2016

We can drop the first sed (which updates xbmc/system.h), but we still need the second sed (updating system/settings/settings.xml) as this is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.