Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service.py: wizard window does not have visible attribute #144

Merged
merged 2 commits into from
Dec 19, 2019
Merged

service.py: wizard window does not have visible attribute #144

merged 2 commits into from
Dec 19, 2019

Conversation

MilhouseVH
Copy link
Contributor

If Kodi is shutdown when the First Run Wizard is active the following exception occurs:

2019-11-16 03:24:54.690 T:1929  NOTICE: stop dvd detect media
2019-11-16 03:24:54.692 T:1951   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <class 'AttributeError'>
                                            Error Contents: 'wizard' object has no attribute 'visible'
                                            Traceback (most recent call last):
                                              File "/usr/share/kodi/addons/service.libreelec.settings/service.py", line 98, in <module>
                                                if oe.winOeMain.visible == True:
                                            AttributeError: 'wizard' object has no attribute 'visible'
                                            -->End of Python script error report<--
2019-11-16 03:24:59.693 T:1929   ERROR: CPythonInvoker(0, /usr/share/kodi/addons/service.libreelec.settings/service.py): script didn't stop in 5 seconds - let's kill it
2019-11-16 03:24:59.889 T:1929  NOTICE: Application stopped

Add a visible attribute to the wizard window, and be a bit more defensive for any window that may not have a visible attribute.

@chewitt chewitt merged commit cc6b2ca into LibreELEC:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants