Add status delete alert in patient event panel #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding this for tracking appointment-delete-related PRs #1116 |
|
Added an alert Cannot create an Appointment with status Deleted to prevent user from making an event with status "Deleted". |
teryhill
approved these changes
May 28, 2018
aethelwulffe
approved these changes
May 28, 2018
There was a problem hiding this comment.
I tested several "scenarios" for the appointments...I don't see any issues, but we should apply this to a "real" database and check again to make sure nothing weird happens. I will stick it on my "double-check" deployment list.
-We really need to start maintaining a "feature change version log".
| return false; | ||
| } | ||
| //alert user if creating appt. with status "Delete"; | ||
| alert('<?php echo addslashes(xl("Cannot create an Appointment with status Deleted")); ?>'); |
There was a problem hiding this comment.
new appt. view model could simply hide that status option...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an alert so that users can re-confirm their decision when deleting patient appointments by selecting status "Delete" and clicking save in event panel. Please have a look @teryhill