-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging appointment delete in calendar #1116
Conversation
Features implemented in these 2 commits:
Recurring appointments case: In case of deletion, it is logged (as a new record with status "Deleted", seq as "1" in tracker-element and as a new record with lastseq as "1" in tracker table) only when:
@teryhill please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the feature change...somewhere...if we have any docs on using the calendar at all :)
It causes an error just an FYI |
would you be a bit more specific, Art tested it live on line with me before we merged and it worked fine. You do have to run the sql_upgrade.... |
change a provider item not a patient
On Wednesday, May 23, 2018, 7:36:52 PM EDT, Tony McCormick <notifications@github.com> wrote:
would you be a bit more specific, Art tested it live on line with me before we merged and it worked fine. You do have to run the sql_upgrade....
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Error? Screen shot? or are you just saying we should revert? |
oops I committed the fix directly to master. Sorry it was just a provider zero fix. @tmccormi |
you da man! |
Issues which this PR deals with:
When user selects "Deleted" status and saves, status is logged but the appointment isn't deleted off calendar.
When user clicks on delete in add-edit-event panel, appointment is deleted off calendar but it is not logged in patient-tracker and patient-tracker-element tables.
Status "Deleted" is added in database.sql file.
@teryhill This first commit attempts on addressing 2nd point. Currently, the issue with it is that "event_date" is passed as NULL upon clicking delete to manage-tracker-status which makes the control flow to go into block at line 204 instead of block at line 218 in patient_tracker and it results in 2 inserts (one in each table) made when clicking delete with one NULL apptdate value coming up in patient-tracker table instead of one update (into patient-tracker) and one insert (into patient-tracker-element). If I pass the date manually, it works by updating lastseq in patient-tracker table in correct id, eid, pid and creating a new record with corresponding id, status "Deleted" and seq updated.