-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#393 Translate German comments #437
#393 Translate German comments #437
Conversation
Translate German comments in NodeNotFoundException file.
Update Headers
@smehrbrodt I had a look at the PR and in general it LGTM. I'm just wondering how it will work with the changes to the copyright year. In 2023 we had the transition of the project from LHM to TDF, but I have no idea how this should be reflected in the headers. |
Yeah, the copyright change does not make sense as-is (the copyright of contributed changes is no longer with the city of Munich). A new, extra line would serve the purpose, reading something like: Copyright © 2022-2023 LibreOffice contributors. All rights reserved. But since the change history is clear from the git log, nowadays there's not that much need for such header lines in the first place. It also adds a lot of noise to the history, if one needs to update the copyright year constantly. |
I was encountered with some build issue to fix that i follow the below instructions from readme file. Let me if i need to make any changes. Build errors |
We might want to get rid of / update to mycila version / disable year updates for the license-maven-plugin. For the moment, there's at least #438 to get LibreOffice contributors properly credited. |
@thorstenb sorry for the late reply, I'm sick. No concerns with the update itself. Feel free to handle the copyright change as you prefer. |
Can you please resolve the conflicts? Then this can be merged. |
Translate German comments in NodeNotFoundException File.
Translate German comments to English in core/src/main/java/de/muenchen/allg/itd51/wollmux/config/NodeNotFoundException.java File.