Add pkg for SOT353 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubruhin
requested changes
Nov 1, 2018
nonoverlapping silkscreen
rename footprint variant
Shrink hand soldering pads
|
@ubruhin good to merge now? 🙂 |
|
Did you see #4 (comment)? ;) |
No. You should unresolve conversations if you add a comment 😉 I forgot the "fixup" comment on the last commit, but you can squash all commits anyways. |
|
🎉 Thanks! |
|
Thank you :)
Oh, I didn't realize that it was already resolved. It's a mess that GitHub automatically resolves discussions when pushing new commits :( |
|
It doesn't, it hides the discussion, but marks it as "outdated". I think I manually resolved that conversation before you added the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular:
Hand soldering variant:
Datasheet: https://www.nxp.com/docs/en/package-information/SOT353.pdf