Library editor menu items are counter-intuitive

[243750496]

hope you can fix

btw: if you choose another two to have a try , you wlll see all three was blue and cannot delete any of them

[ubruhin]

Oh that's a misleading GUI. These menu items should be disabled if no library element is open. To remove whole library elements, currently the only way is to open it and then choose File -> Remove Element.

[243750496]

find still no able to delete anythins with File -> Remove Element. and update library
maybe it's a bug

[243750496]

this is the rightway to do delete , in main page after opened the library manager , we can not delete it

only can delete it with opened the item , please correct it , it's a worg guide to show up in main page without function

[ubruhin]

@0xB767B Maybe you could improve the GUI to avoid confusion? Most important would be to disable/enable some menu items depending on the current state of the library editor.

In addition, it would be nice to allow removing library elements without the need for opening them first.

[0xB767B]

@ubruhin Are there any general concepts in LibrePCB how to enable/disable menu-items based on some state of the program?

[ubruhin]

Not really. I guess the library editor is currently the only window which enables/disables some QActions depending on which kind of library element is currently open. And the implementation of that is quite pragmatic ;)

Btw, now I noticed that some QActions in the toolbars are disabled properly, but not their corresponding menu items (most QAction objects are added to both, a toolbar and a menu).

[lukabosnjakovic]

I had similar problem few minutes a go. It is not intuitive that you must first open element and than go to Edit > Remove. My proposal is that maybe you add context menu (right click on element) with remove option. This is more intuitive to me.

[dbrgn]

I'd nominate this for the 0.1 final 🙂

[ubruhin]

I'm ready to accept pull requests ;)

[ubruhin]

Context menu added in #380.

Btw, now I noticed that some QActions in the toolbars are disabled properly, but not their corresponding menu items (most QAction objects are added to both, a toolbar and a menu).

Fixed in c0d39eb.