Board editor: Tool to measure wire length #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubruhin
requested changes
Oct 26, 2019
dbrgn
force-pushed
the
measure-segment-length
branch
from
44c403a
to
455fa58
Compare
|
I think all comments should be addressed now. |
You forgot one 🙂:
And CI seems to be broken now ;) |
ubruhin
reviewed
Oct 29, 2019
WTF, I did fix that, but for some reason it got lost during rebasing... |
dbrgn
force-pushed
the
measure-segment-length
branch
from
455fa58
to
7a55934
Compare
|
Hopefully CI should be fixed now. It was due to a unused-variable warning. |
When right-clicking on an element in the board editor, if the right-clicked element is part of an active selection, keep it as-is. However, if it's not part of an active selection, clear the selection and select the right-clicked element instead.
dbrgn
force-pushed
the
measure-segment-length
branch
from
7a55934
to
f75dd96
Compare
The tool in the right-click context menu measures the total length of all selected netlines directly connected to the netline below the cursor.
dbrgn
force-pushed
the
measure-segment-length
branch
from
f75dd96
to
590b869
Compare
ubruhin
approved these changes
Oct 30, 2019
|
Thanks! 👍 |
ubruhin
added a commit
that referenced
this pull request
Nov 17, 2019
Board editor: Tool to measure wire length (cherry picked from commit 7a75aa3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow measuring the length of the selected wire segment.
If not all selected netlines are directly connected, a warning is shown.
The functionality is currently quite limited. It only measures from start point to end point and does not consider the width of the netline. However, it's quite hard to define what the correct behavior should be.
Other changes in this PR:
Point::getLengthnow returnsUnsignedLengthBI_NetLinenow has agetLengthmethod