Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pom.xml and create a new Maven Release to reflect organizational ownership. #3

Closed
bengolder opened this issue Oct 27, 2016 · 22 comments

Comments

@bengolder
Copy link
Collaborator

No description provided.

@ghost
Copy link

ghost commented Oct 31, 2016

A new release would be a good idea!

@ghost
Copy link

ghost commented Nov 24, 2016

Any news on the new maven release? It would be nice to get a release out.

@nwinkler
Copy link

Do you want me to create a PR for the pom.xml updates with the new groupId?

What should it be? com.github.librepdf?

@ghost
Copy link

ghost commented Jan 16, 2017

Yes, please. com.github.librepdf seems fine to me.

@nwinkler
Copy link

OK, will do. We'll have to talk about what we want to do with the existing 1.0 version that's out on Maven Central, since that's using the existing groupId. Do we want to add a redirect to the new groupId in there? (Not sure how to do that, but I've seen it used before.)

nwinkler pushed a commit to nwinkler/OpenPDF that referenced this issue Jan 16, 2017
@nwinkler
Copy link

Opened PR in #12.

For the updated release - what version number would that use? Since it's a change in the groupId, it probably shouldn't be done in a patch release (1.0.1)...

@ghost
Copy link

ghost commented Jan 16, 2017

How about 1.1 ?

@bengolder
Copy link
Collaborator Author

@nwinkler or @andreasrosdal I can queue up a new release as I did last time. I think it would be useful collaborate with one or both of you on the process so that more committers are able to publish releases. Would either of you like to work with me to do the release?

@ghost
Copy link

ghost commented Jan 17, 2017

A new release would be nice. Perhaps you can email me your notes after making the release?

@nwinkler
Copy link

Now that the Wiki is enabled, we should probably document the release process on a Wiki page.

I've done an internal, private release of OpenPDF with the OSGi changes I made (since I needed them) yesterday, and it worked fine without any hitches. All I had to do was to remove the distribution settings (and the nexus-deploy plugin) and add our own Maven repo as the distribution target. Then it was just using the Maven Release Plugin as on any other project.

One other thing that I'm interested in is the GPG setup. I had to install GPG on my Mac, generate a key, and run gpg-agent to make it through the build. Whenever GPG Agent times out, I have to enter my passphrase again during the build. How is this going to be handled for automated builds/continuous integration, e.g. on Travis CI?

@ghost
Copy link

ghost commented Jan 18, 2017

Travis CI currently skips the GPG part:
mvn install -Dgpg.skip
https://github.com/LibrePDF/OpenPDF/blob/master/.travis.yml

@nwinkler
Copy link

Ah, cool - didn't know that! Thanks!

@ghost
Copy link

ghost commented Jan 25, 2017

@bengolder How about a new release of OpenPDF now?

@bengolder
Copy link
Collaborator Author

bengolder commented Jan 28, 2017

@andreasrosdal Absolutely. My apologies for the delay. Thank you for nudging me. Working on it now, reviewing my notes.

@bengolder
Copy link
Collaborator Author

bengolder commented Jan 28, 2017

I'm adding some notes to this wiki page:
https://github.com/LibrePDF/OpenPDF/wiki/Release-Process

@bengolder
Copy link
Collaborator Author

bengolder commented Jan 28, 2017

I've added a ticket to claim the groupId com.github.librepdf and the repository:
https://issues.sonatype.org/browse/OSSRH-27890

Once the repository is created, I'll finish the steps to create a new release and document more of the process on the wiki.

@andreasrosdal I've added your JIRA username so that you'll have permission to do releases.
@nwinkler if you give me your JIRA username, I'd be happy to add you as another maintainer with permission to publish.

@bengolder
Copy link
Collaborator Author

bengolder commented Jan 28, 2017

The repository has been created! Moving forward.

  • publish a staging release
  • publish a main release
  • Add final notes on how to publish the version release.

I believe 1.0.1 is now officially published! If someone could verify by installing it as a dependency, I'll close this issue.

@bengolder
Copy link
Collaborator Author

bengolder commented Jan 29, 2017

I'm bad at version management. Should I bump all the pom.xml files to say 1.0.2-SNAPSHOT, 1.0.2, or 1.0.1-SNAPSHOT?

I used 1.0.1-SNAPSHOT for now, but please let me know which you think is best. We should update the final step in our release instructions to reflect whichever we choose.

Let me know if the instructions in the wiki are clear. Feel free to walk through all the steps apart from mvn nexus-staging:release if you'd like to make sure you can complete them.

@ghost
Copy link

ghost commented Jan 30, 2017

I can confirm that I can install OpenPDF version 1.0.1 through Maven. Great job @bengolder !

I have no strong opinions on the snapshot versining convention.

Thanks!

@ghost ghost closed this as completed Jan 30, 2017
@nwinkler
Copy link

Since 1.0.1 has been released, the next SNAPSHOT version should be 1.0.2-SNAPSHOT- it needs to be one higher than the release version, since the SNAPSHOT is the next version that we will be working on.

Will review later and provide some more feedback - I'm about to board a plane.

@nwinkler
Copy link

Had a look at the release instructions in the Wiki. It should be possible to create the release (including updating the version numbers, Git tag, uploading, etc.) by using the Maven Release Plugin: http://maven.apache.org/maven-release/maven-release-plugin/

I've done an internal release recently using the release plugin, and it worked by simply doing the following:

mvn -B -DreleaseVersion=1.0.1 -DdevelopmentVersion=1.0.2-SNAPSHOT release:prepare

mvn release:perform

This should do everything required, no other manual steps required.

I'll try to update the Wiki when I have time.

@bengolder
Copy link
Collaborator Author

bengolder commented Jan 31, 2017

Thanks @nwinkler. I updated the version to 1.0.2-SNAPSHOT
The Maven Release plugin does look easier. Next time we need to do a release I think it's worth a try. If you want to do use it or add the documentation please go for it, it sounds helpful.

andreasrosdal pushed a commit that referenced this issue Aug 8, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants