-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker multi stage build #17
Conversation
Alright, I created and uploaded the image. Building worked fine. The image name is derneuere/librephotos:multistage To use the image you have to replace this line librephotos-docker/docker-compose.yml Line 42 in bf9fdcd
There are three different kinds of scenarios we have to test: The test is successful if the user can login via the frontend. I will ask on discord if anyone wants to help out :) |
Does it work for you? I tried the new image, but it failed:
My CPU doesn't have AVX. But when I look at the changes in this PR, I don't see how is it supposed to compile the image with or without AVX? |
Got busy at work for a bit and the Dockerfile has changed quite heavily. I'll follow up on discord separately on how to improve this because the container is now ballooned up to nearly 8 gigs in size |
As the build changed quite a bit, I will close this down. I think that #45 is the better way forward in order to reduce the size further. |
Creating a first draft, but may not work as intended. Needs some sanity checks from people that know the different details that are needed to run this. Also not tested by running the generated container bc I'm not clear on how the command is run. Details would be appreciated!