Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newcert request when names array is empty #1161

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix newcert request when names array is empty #1161

merged 1 commit into from
Nov 9, 2022

Conversation

lhsazevedo
Copy link
Collaborator

Previously, an empty item was sent inside the names array when no names other than CN were set. This was making CFSSL API fail with an 400 BAD REQUEST response.

To reproduce the issue and verify the fix:

  • Make sure you are in the main branch
  • Regenerate the root certificate, setting the CN field only.
  • Try to update your LibreSign password, it should fail.
  • Switch to this branch and try to update the password again, it should succeed.

@lhsazevedo
Fix newcert request when names array is empty
ed216c4 
Previously, an empty item was sent inside the names array when no
names other than CN were set. This was making CFSSL API fail with an
400 BAD REQUEST response.

Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
@vitormattos
Copy link
Member

/backport to stable25

@vitormattos vitormattos merged commit 34a2053 into LibreSign:main Nov 9, 2022
@backportbot-libresign backportbot-libresign bot mentioned this pull request Nov 9, 2022
Merged
@lhsazevedo lhsazevedo deleted the fix-empty-names branch February 4, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhsazevedo @vitormattos