-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PVC accessMode configurable #120
Conversation
Rather than making the PV accessMode defined by the replica count this allows users to set it directly. Tieing the accessMode to replicaCounts make it difficult for users to make changes in the future without also forcing an accessMode change, which can be disruptive. The previous logic set it so that a PVs were provisioned with ReadWriteMany when defaults are used, this retains that behavior.
LGTM, although IMO we should keep the default behavior (as in, if it isn't set in the helm values, the Also, currently ngshare uses SQLite as the database, and we aren't sure if multiple instances of ngshare can use the same underlying SQLite database mounted ReadWriteMany without race conditions. Just a heads up. |
…ve access to encrypted variables
I agree, but when I render the template locally I get The PR maintains the current behavior when replicas equals 1. If that's a bug I'm happy to submit a patch for that too. |
Whoops, that's definitely a bug. I guess we can just add a note in the changelog and mention this bug, and the default behavior can just be |
How does this look? |
LGTM - do you want to change the default value here or leave it as |
I think leaving it as |
Sounds good - I know changing defaults can cause weird problems for folks. |
Rather than making the PV accessMode defined by the replica count this allows users to set it directly. Tieing the accessMode to
replicaCounts make it difficult for users to make changes in the future without also forcing an accessMode change, which can be disruptive.
The previous logic set it so that a PVs were provisioned with ReadWriteMany when defaults are used, this retains that behavior.