Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I contributed before, and while reviewing the project now, dealing with the CSS has been very painful due to how theming is handled.
The way most projects handle theming, is using CSS variables on
:root
which can then be used throughout the site. Then overriding those variables either on a media query or a class.Here are examples from the Exercism and Microsoft websites, respectively:
This offers a few benefits:
.white
which, gets overridden to black in dark mode.This should avoid problems like this in future:
The goal is to leave the site the same (or better), but reduce CSS and make theming easier to maintain.
I've made some subtle changes, intentionally:
Screenshots
Light Mode After (Left) and Before (Right)
Dark Mode After (Left) and Before (Right)
PS: I hope to polish the UI and improve accessibility soon, but before that, I'm doing chores to make the project easier to maintain.